Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: distinct VPC host prep examples #894

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: distinct VPC host prep examples #894

merged 1 commit into from
Mar 12, 2024

Conversation

alaincormier-ssc
Copy link
Collaborator

in preparation for feature #883

update for examples

  • dns:
    • update setter to use dns-project-id instead of host-project-id
  • firewall-policy-rules:
    • edit spec.firewallPolicyRef to reference the policy on the "classification" folder

lucstjean-ssc
lucstjean-ssc approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fmichaelobrien
fmichaelobrien approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alaincormier-ssc alaincormier-ssc merged commit bd3a614 into main Mar 12, 2024
2 checks passed
@alaincormier-ssc alaincormier-ssc deleted the gh883-examples branch March 12, 2024 17:30
@alaincormier-ssc alaincormier-ssc mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichaelobrien fmichaelobrien fmichaelobrien approved these changes

@lucstjean-ssc lucstjean-ssc lucstjean-ssc approved these changes

@Michael-McAuley-SSC Michael-McAuley-SSC Awaiting requested review from Michael-McAuley-SSC

@davelanglois-ssc davelanglois-ssc Awaiting requested review from davelanglois-ssc

@CraigBaltzer CraigBaltzer Awaiting requested review from CraigBaltzer

@stephanemillaire-ssc stephanemillaire-ssc Awaiting requested review from stephanemillaire-ssc

@seanwilkens-ssc seanwilkens-ssc Awaiting requested review from seanwilkens-ssc

@anoopsidhu-ssc anoopsidhu-ssc Awaiting requested review from anoopsidhu-ssc

@borkodjurkovic-ssc borkodjurkovic-ssc Awaiting requested review from borkodjurkovic-ssc

@johnswayty-ssc johnswayty-ssc Awaiting requested review from johnswayty-ssc

@tackaberry tackaberry Awaiting requested review from tackaberry tackaberry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaincormier-ssc @lucstjean-ssc @fmichaelobrien