Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cbrid to experimentation core landing zone #903

Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat: add cbrid to experimentation core landing zone #903

merged 1 commit into from
Mar 18, 2024

Conversation

anoopsidhu-ssc
Copy link
Collaborator

closes #902

@anoopsidhu-ssc anoopsidhu-ssc self-assigned this Mar 18, 2024
lucstjean-ssc
lucstjean-ssc approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fmichaelobrien
fmichaelobrien approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Label template looks good
I would expect a kpt-set but I don't have the full context to verify that in this case

@anoopsidhu-ssc
Copy link
Collaborator Author

/lgtm

Label template looks good I would expect a kpt-set but I don't have the full context to verify that in this case

We dont need a setter to set labels as there is a set label project yaml that will be called by mutator function in kpt file

@anoopsidhu-ssc anoopsidhu-ssc merged commit 3724763 into main Mar 18, 2024
3 checks passed
@anoopsidhu-ssc anoopsidhu-ssc deleted the gh902-cbrid-corelandingzone branch March 18, 2024 21:03
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichaelobrien fmichaelobrien fmichaelobrien approved these changes

@lucstjean-ssc lucstjean-ssc lucstjean-ssc approved these changes

@tackaberry tackaberry Awaiting requested review from tackaberry tackaberry is a code owner

@davelanglois-ssc davelanglois-ssc Awaiting requested review from davelanglois-ssc

Assignees

@anoopsidhu-ssc anoopsidhu-ssc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding cbr id to experimentation core landing zone
3 participants
@anoopsidhu-ssc @lucstjean-ssc @fmichaelobrien