env validation moved inside function on github modlues api

GoogleCloudPlatform · Sep 29, 2023 · 96edc92 · 96edc92
1 parent 6794a6b
commit 96edc92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/radlab-ui/webapp/src/pages/api/github/index.ts b/radlab-ui/webapp/src/pages/api/github/index.ts
@@ -4,14 +4,15 @@ import { withAuth } from "@/utils/middleware"
 import { AuthedNextApiHandler } from "@/utils/types"
 import { NextApiResponse } from "next"
 
-const GIT_TOKEN_SECRET_KEY_NAME = envOrFail(
-  "GIT_TOKEN_SECRET_KEY_NAME",
-  process.env.GIT_TOKEN_SECRET_KEY_NAME,
-)
 const getModuleDataFromGitHub = async (
   req: AuthedNextApiHandler,
   res: NextApiResponse,
 ) => {
+  const GIT_TOKEN_SECRET_KEY_NAME = envOrFail(
+    "GIT_TOKEN_SECRET_KEY_NAME",
+    process.env.GIT_TOKEN_SECRET_KEY_NAME,
+  )
+
   const { path } = req.body
   const secret = await getSecretKeyValue(GIT_TOKEN_SECRET_KEY_NAME)
   try {

diff --git a/radlab-ui/webapp/src/pages/api/github/modules.ts b/radlab-ui/webapp/src/pages/api/github/modules.ts
@@ -4,14 +4,14 @@ import { withAuth } from "@/utils/middleware"
 import { AuthedNextApiHandler } from "@/utils/types"
 import { NextApiResponse } from "next"
 
-const GIT_TOKEN_SECRET_KEY_NAME = envOrFail(
-  "GIT_TOKEN_SECRET_KEY_NAME",
-  process.env.GIT_TOKEN_SECRET_KEY_NAME,
-)
 const getModulesFromGitHub = async (
   _req: AuthedNextApiHandler,
   res: NextApiResponse,
 ) => {
+  const GIT_TOKEN_SECRET_KEY_NAME = envOrFail(
+    "GIT_TOKEN_SECRET_KEY_NAME",
+    process.env.GIT_TOKEN_SECRET_KEY_NAME,
+  )
   const secret = await getSecretKeyValue(GIT_TOKEN_SECRET_KEY_NAME)
   const modules = await getGitHubModules(secret)
   return res.status(200).json(modules)