-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email notifications for create,update,delete deployment #182
Merged
acolver
merged 16 commits into
GoogleCloudPlatform:staging
from
GPS-Demos:email_trigger
Sep 29, 2023
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
069e07d
Email notifications
SachinSogoduRaju 7006df1
email notification changes
SachinSogoduRaju 70c05fe
email notification implementation
SachinSogoduRaju 5286bf0
Description of email notification check box updated
SachinSogoduRaju 4f3b044
Update radlab-ui/webapp/src/components/forms/DefaultStepCreator.tsx
SachinSogoduRaju 02fd980
Update radlab-ui/webapp/src/utils/mailHandler.ts
SachinSogoduRaju d22a83d
Update radlab-ui/webapp/src/utils/mailHandler.ts
SachinSogoduRaju 9d0deba
PR review Changes
SachinSogoduRaju b9a5dc9
Update radlab-ui/webapp/src/utils/mailHandler.ts
SachinSogoduRaju e500a51
Update docs/docs/rad-lab-ui/ui_installation/env-variables.md
SachinSogoduRaju fa42080
updated mailhandler function
SachinSogoduRaju 1d1fb57
Update docs/docs/rad-lab-ui/troubleshooting.md
SachinSogoduRaju fc5579d
Add fallback value to SECRET_MANAGER_LOCATION. Update some variable d…
acolver d176819
updated troubleshooting doc
SachinSogoduRaju bf43e99
Update docs/docs/rad-lab-ui/troubleshooting.md
acolver 3e8ea66
Update docs fro email notifications and env moved to terraform output
SachinSogoduRaju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
radlab-ui/webapp/public/assets/htmlTemplates/deleteEmail.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<html> | ||
<head> | ||
<style></style> | ||
</head> | ||
<body> | ||
<h3>Hello!</h3> | ||
<p> | ||
RAD Lab Module with deployment ID - | ||
<a href="{{{deployment_link}}}" style="border: 0" target="_blank"> | ||
{{deploymentId}}</a | ||
> | ||
has been successfully deleted! | ||
</p> | ||
|
||
<br /> | ||
<p>Thank you<br /></p> | ||
<img | ||
style="width: 8rem; height: 2rem" | ||
src="https://github.com/GPS-Demos/rad-lab/blob/main/radlab-ui/webapp/public/assets/images/logo.png?raw=true" | ||
/> | ||
<p>P.S:- This is an auto generated email. Please do not reply!</p> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<html> | ||
<head> | ||
<style> | ||
table { | ||
font-family: arial, sans-serif; | ||
border-collapse: collapse; | ||
width: 40%; | ||
} | ||
|
||
td, | ||
th { | ||
border: 1px solid #dddddd; | ||
text-align: left; | ||
padding: 8px; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<h3>Hello!</h3> | ||
<p>{{mailBodyTitle}}</p> | ||
<p>Please use below details to access the same.</p> | ||
|
||
<table id="myTable"> | ||
<tr> | ||
<th>Name</th> | ||
<th>value</th> | ||
</tr> | ||
<tr> | ||
<td>Project Id</td> | ||
<td> | ||
<a href="{{{gcp_project_link}}}" style="border: 0" target="_blank" | ||
>{{projectId}}</a | ||
> | ||
</td> | ||
</tr> | ||
<tr> | ||
<td>Deployment Id</td> | ||
<td> | ||
<a href="{{{deployment_link}}}" style="border: 0" target="_blank" | ||
>{{deploymentId}}</a | ||
> | ||
</td> | ||
</tr> | ||
{{#outputs}} | ||
<tr> | ||
<td>{{name}}</td> | ||
<td>{{value}}</td> | ||
</tr> | ||
{{/outputs}} | ||
</table> | ||
|
||
<br /> | ||
<p>Thank you<br /></p> | ||
<img | ||
style="width: 8rem; height: 2rem" | ||
src="https://github.com/GPS-Demos/rad-lab/blob/main/radlab-ui/webapp/public/assets/images/logo.png?raw=true" | ||
/> | ||
<p>P.S:- This is an auto generated email. Please do not reply!</p> | ||
</body> | ||
</html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 Questions:
How are we setting this Environment variable ? Are we needing admins to manually update the .env file with the region before UI deployment or using the existing bash script which creates the .env file.
What is the default value of this variable ? Is it the same as app_engine_location variable ?
SOLUTION: If its manually set and we want to automate it like other variables we can expose the above
app_engine_location
variable as a TF output and we can use the existing bash script to create the .env with the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app_engine_location
andSecret Manager Location
are different things so created new env inoutputs
and updated inbash script
file.