API to fetch RAD Lab modules data from git repo #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinSogoduRaju
requested review from
acolver,
debakkerb and
guptamukul-google
as code owners
|
Thank you for raising the request! RAD Lab admins have been notified. |
|
Apache 2.0 License check successful! |
acolver
reviewed
Sep 28, 2023
Comment on lines
7
to
10
| const GIT_TOKEN_SECRET_KEY_NAME = envOrFail( | ||
| "GIT_TOKEN_SECRET_KEY_NAME", | ||
| process.env.GIT_TOKEN_SECRET_KEY_NAME, | ||
| ) |
There was a problem hiding this comment.
Will the whole app fail to start if this is not provided? Is this optional (as in we by default pull from GoogleCloudPlatform/radlab)? If so, can we move the envOrFail into the handler itself (getModuleDataFromGithub).
There was a problem hiding this comment.
This block of code can be moved inside handler function since app will not fail to start if not provided.
Code modified accordingly.
acolver
approved these changes
Sep 29, 2023
|
Closing this PR to create a new PR for entire feature including front end and backend code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.