-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Depends on functionalities and Set mandatory fields via UI Meta flag #187
base: staging
Are you sure you want to change the base?
Feature Depends on functionalities and Set mandatory fields via UI Meta flag #187
Conversation
Depends on functionalities and Set mandatory fields via UI Meta flag
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thank you for raising the request! RAD Lab admins have been notified. |
Apache 2.0 License check successful! |
Update document for mandatory and depends on flag
update change mandatory to required UI meta tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed is we are still saving values of dependent variables if they have a default.
For example. I don't create a budget but I am still saving budget amount (500). I think this is probably fine but want @guptamukul-google opinion
@saurabhkg891 When I toggle a checkbox it (correctly) shows more fields that are required. However, if I uncheck I cannot click "Next" until I trigger a |
@saurabhkg891 Also, if I have an invalid form (e.g. haven't filled out some required fields) and I click "Previous", the previous--valid--form won't let me click "Next" until I retrigger validation (e.g. uncheck and recheck a box) |
Depends on functionalities and Set mandatory fields via UI Meta flag
Resolving issues: #140