Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Depends on functionalities and Set mandatory fields via UI Meta flag #187

Open
wants to merge 12 commits into
base: staging
Choose a base branch
from

Conversation

saurabhkg891
Copy link

Depends on functionalities and Set mandatory fields via UI Meta flag

Resolving issues: #140

Depends on functionalities and Set mandatory fields via UI Meta flag
@google-cla
Copy link

google-cla bot commented Oct 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Thank you for raising the request! RAD Lab admins have been notified.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Apache 2.0 License check successful!

radlab-ui/webapp/src/utils/terraform.ts Show resolved Hide resolved
radlab-ui/webapp/src/utils/terraform.ts Outdated Show resolved Hide resolved
radlab-ui/webapp/src/utils/terraform.ts Outdated Show resolved Hide resolved
radlab-ui/webapp/src/utils/terraform.ts Outdated Show resolved Hide resolved
docs/docs/rad-lab-ui/ui_configure/ui-meta.md Outdated Show resolved Hide resolved
radlab-ui/webapp/__mocks__/terraform.ts Outdated Show resolved Hide resolved
radlab-ui/webapp/__mocks__/terraform.ts Outdated Show resolved Hide resolved
docs/docs/rad-lab-ui/ui_configure/ui-meta.md Outdated Show resolved Hide resolved
docs/docs/rad-lab-ui/ui_configure/ui-meta.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@acolver acolver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I noticed is we are still saving values of dependent variables if they have a default.

For example. I don't create a budget but I am still saving budget amount (500). I think this is probably fine but want @guptamukul-google opinion

docs/docs/rad-lab-ui/ui_configure/ui-meta.md Outdated Show resolved Hide resolved
@acolver
Copy link
Collaborator

acolver commented Oct 5, 2023

@saurabhkg891 When I toggle a checkbox it (correctly) shows more fields that are required. However, if I uncheck I cannot click "Next" until I trigger a blur event. (see screenshot). Can we have the form validation run onChange instead of onBlur?
image

@acolver
Copy link
Collaborator

acolver commented Oct 5, 2023

@saurabhkg891 Also, if I have an invalid form (e.g. haven't filled out some required fields) and I click "Previous", the previous--valid--form won't let me click "Next" until I retrigger validation (e.g. uncheck and recheck a box)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants