Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX [Issue-70]: log error when dequeue fails instead of panic #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX [Issue-70]: log error when dequeue fails instead of panic #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pipeline/senders/retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ func (rs *RetryingSender) maybeSend(now time.Time) {
// In either scenario, the report is removed from the queue and the retry delay is reset.
if poperr := rs.queue.Dequeue(nil); poperr != nil {
// We failed to pop the sent entry off the queue. This isn't recoverable.
panic("RetryingSender.maybeSend: dequeuing from retry queue: " + poperr.Error())
glog.Errorf("RetryingSender.maybeSend: dequeuing from retry queue: " + poperr.Error() + " we've either successfully sent the report or encountered a non-transient error")
return
}

rs.lastAttempt = now
Expand Down