feat(go): support go 1.23 and delve 1.23.1 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
henrymcconville
commented
Nov 25, 2024
•
henrymcconville
commented
- Upgrade Go to 1.23
- Upgrade Delve to 1.23.1
- Update Delve patch based on Delve 1.23 codebase
- Add tests for go 1.21-1.23
- Remove unused tests for Go 1.13-1.17
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
henrymcconville
force-pushed
the
feat/delve1.23.1
branch
from
dbb3da9 to
a006f77
Compare
henrymcconville
force-pushed
the
feat/delve1.23.1
branch
from
a006f77 to
47b98a6
Compare
|
@plumpy done! |
|
Thanks a lot! Could you possibly make a release? When will Skaffold (https://github.com/GoogleContainerTools/skaffold) pick up the changes and make a release? |
|
Yep, I created a release (accidentally jumped straight from 1.4 to 1.6... oops) and Skaffold should start using it automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.