[3935] Retry on unsuccessful code too

[rmannibucau]

Before filing a pull request, make sure to do the following:

• Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose.
• Ensure that your implementation plan is approved by the team.
• Verify that integration tests and unit tests are passing after the change.
• Address all checkstyle issues. Refer to the style guide.

This helps to reduce the chance of having a pull request rejected.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[fahedouch]

Hello, thank you for your effort, Is it possible to handle 502 too ? ( issue raised here)

[rmannibucau]

Hi @fahedouch , did you try and got and issue with 502/503? It should be in when possible.

[fahedouch]

502

thanks a lot :D. yes I got an issue with 502

[rmannibucau]

@fahedouch ok, if this patch is not sufficient once applied, maybe clone master, apply this diff, duplicate the test, return a 502 in the test and check the exception thrown cause if with this patch you still have 502 issues it either means the request was not retryable (unlikely but possible in rare cases) or that the IOExceptionHandler does not handle 502 properly which shouldn't and must be fixed in the http dependency.

[fahedouch]

@fahedouch ok, if this patch is not sufficient once applied, maybe clone master, apply this diff, duplicate the test, return a 502 in the test and check the exception thrown cause if with this patch you still have 502 issues it either means the request was not retryable (unlikely but possible in rare cases) or that the IOExceptionHandler does not handle 502 properly which shouldn't and must be fixed in the http dependency.

Ah Sorry I tried with a tag, I will try with your PR and keep you updated. I hope that jib community move this PR forward.