-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear artboard #2015
base: master
Are you sure you want to change the base?
Clear artboard #2015
Conversation
Note that merge nodes are named "Artboard" as I reserve the name |
645becf
to
ac49479
Compare
!build |
|
I would like to see the artboards name/position/downstream connnector/upstream connectors being saved, then the artboard is deleted, a layer node is created, its name/position are set, then it is reconnecting. All using the same messages as if the user was to do it. Also, make sure to start and end a transaction at the start and end of the message. Its also important that no mutable network interface functions are called in a message that has a start/end transaction. Optionally, it would also be nice if the artboards position is then used to set the transform of the new layer, so that the contents stay at the same place. This would require using a monitor node to access the artboard data, where the translation is stored. This could also be used to improve #2028. This would probably be outside the scope of the PR, so you could leave a TODO. |
I'll mark this as a draft until those comments are addressed. Thanks for taking the time to review this, @adamgerhant. |
You want to reduce loops by this right? |
You can use however many loops are necessary to achieve the correct behavior |
Just checking in on the status of this @moOsama76. |
I was taking a break, will do it this week |
No description provided.