Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented left selection logic #2124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implemented left selection logic #2124

wants to merge 1 commit into from
+27 −1

Conversation

pratikagr
Copy link
Contributor

@pratikagr pratikagr commented Dec 1, 2024 •
edited
Loading

This PR addresses issue #2041

  1. Added logic to calculate the drag direction (left or right) using calculate_direction.
  2. Integrated the intersect_quad_no_artboards function for leftward drags to select all intersecting objects.
  3. Updated the selection process to differentiate between leftward (intersects).
  4. Rightward drag is yet to be implemented. i am working on it.

Closes #

@0HyperCube 0HyperCube marked this pull request as draft December 1, 2024 09:08
@Keavon
Copy link
Member

Keavon commented Dec 1, 2024

Hello, could you please link to which issue this pertains to? Based on your description, I'm not familiar with what this aims to implement.

@pratikagr
Copy link
Contributor Author

Hello, could you please link to which issue this pertains to? Based on your description, I'm not familiar with what this aims to implement.

My bad, this PR addresses issue #2041

@Keavon
Copy link
Member

Keavon commented Dec 2, 2024

Please be sure to include that in the original PR description.

@pratikagr pratikagr marked this pull request as ready for review December 3, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratikagr @Keavon