Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mPDF HTTP Request with wp_remote_get() #1441

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jakejackson1
Copy link
Member

Description

Resolve issues loading images / assets when using mPDF's native cURL functionality.

Fixes #1440

Testing instructions

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1441 (157701d) into development (b9671fd) will increase coverage by 17.60%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             development    #1441       +/-   ##
==================================================
+ Coverage          75.70%   93.30%   +17.60%     
==================================================
  Files                243       57      -186     
  Lines              12826     1464    -11362     
  Branches             370      370               
==================================================
- Hits                9710     1366     -8344     
+ Misses              3108       90     -3018     
  Partials               8        8               
Impacted Files Coverage Δ
src/Helper/Helper_PDF.php
src/Helper/Fields/Field_Tax.php
src/View/html/Settings/tools.php
src/Helper/Helper_Options_Fields.php
src/templates/zadani.php
src/Model/Model_Mergetags.php
src/Helper/Fields/Field_Quantity.php
src/Model/Model_PDF.php
src/Controller/Controller_Settings.php
src/Controller/Controller_Install.php
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Resolve issues loading images / assets when using mPDF's native cURL functionality.

Fixes #1440
@jakejackson1 jakejackson1 force-pushed the mpdf-http-replacement branch from 2ea7615 to 157701d Compare January 1, 2023 23:01
@jakejackson1 jakejackson1 marked this pull request as draft January 1, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Display Problems
1 participant