Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stun Expiration #613

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Commits on Sep 10, 2021

  1. Start replacement logic for Stunned countdown

    - There's an extra signal sent on wrapping around in initiative that
      breaks the logic for when to tick because both new and old initiative
      numbers are 0
    - The logic is still faulty if there are duplicate initiative numbers,
      but this at least replicates what seems to be the intended original
      behavior.
    dolio committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    630e39d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Configuration menu
    Copy the full SHA
    1d9e7dc View commit details
    Browse the repository at this point in the history
  2. Tweak initiative counting logic

    - There seems to have been a mistake translating it from the original,
      which always caused a 0->0 update message, rather than an N->0 update
      message on wrapping around (and thus no N->0 message was sent before
      the 0->MAX message, causing some intervals to be skipped).
    - There probably shouldn't be an N->0 message when N is already <=0 due
      to actual rolled initiatives being that low.
    dolio committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    b85b483 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. Tweak/document stun tick logic

    - Clarify relation to initiative signals, and generalize the avoidance
      of 'degenerate' messages, although they shouldn't occur anymore.
    - Made the intervals mentioned in the comments no longer backwards.
    dolio committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    3fdd76d View commit details
    Browse the repository at this point in the history