Resolution to Issue #20, Partial Resolution to Issue #4 and new toggle functionality #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made toLower an optional text style Added "allowToggle" input to control if menu autoToggles allowToggle enables a save button to report errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version adds the ability to add custom svg icons to the buttons instead of being restricted to material icons. This should assist in resolution of #4. To use a custom icon it must be included in the project assets and the path and a custom name must be supplied to the button (parent menu button or child buttons will work)
The lowercase text css has been split into it's own class and a "toLower" input has been supplied to add the lowercase text styling if required. by default this is false and text appears normal. This should resolve #20.
An additional input "allowToggle" has been added - this allows the automatic retraction of the menu to be stopped if required. An example is if you are using the menu for an edit/save scenario, the save button press will not Toggle the menu if you set the allowToggle to false when validation fails.
Note that I have been unable to build the original project, I am testing the modified code in a new Angular 6 project and has been working, but may want to verify it still builds for the targeted version of angular.