Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Programmable Search Engine to 1-Sidebar and 2-404 page #335

Merged

Conversation

loricooperhdf
Copy link
Collaborator

I'm not sure how this will render. (Internal JIRA ticket: https://hdfgroup.atlassian.net/browse/IWIP-544)

We haven't run this through committee. However, I think it's valid and important. (#YOLO.)

@@ -5,4 +5,10 @@ title: 404 - Content Not Found

# This page doesn't seem to exist

## Search all Support Content
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search looks good.
Not sure why "This page doesn’t seem to exist" renders this way in Codespace and VSCode. But it looks fine when the html is viewed from SUPPORT

image

@@ -52,6 +52,12 @@
</ul>
{% endif %}
-->

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search needs better formatting... doesn't fit in the column.
Move to Body?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@lkurz lkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some adjustment to side nav search. Relocate?

@loricooperhdf
Copy link
Collaborator Author

I tried something different, different functionality for search as provided by Google. Fit may still be an issue but the search content it won't load in preview in github codespaces for me, and I can't tell if it works, either. Can you check on this @lkurz?

@lkurz
Copy link
Collaborator

lkurz commented Nov 1, 2024

I tried something different, different functionality for search as provided by Google. Fit may still be an issue but the search content it won't load in preview in github codespaces for me, and I can't tell if it works, either. Can you check on this @lkurz?

When you configure the PSE configuration to send to a results page it asks you for the url to return the results to.
Currently it is https://support.hdfgroup.org/results.html. the results will go to that page and not the page of the codespace. This results page does not exist yet on support.hdfgroup.org so you when you search from codespace the PSE sends to SUPPORT and you get a 404.

During testing you can change the PSE results url to your codespace results page and it works.

@loricooperhdf
Copy link
Collaborator Author

During testing you can change the PSE results url to your codespace results page and it works.

Are you saying this works? I couldn't figure out what URL to grab to plugin for the temp results page. Tried this, no change in results... (https://github.com/loricooperhdf/HDFGroup.github.io/blob/47da40550d0e5fa09b301ba05a66c7356bcf9cac/results.html)

Copy link
Collaborator

@lkurz lkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now.

@lkurz
Copy link
Collaborator

lkurz commented Nov 1, 2024

Created search folder and index.md file.
Layout search now links to there.

@lkurz lkurz merged commit 5396934 into HDFGroup:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants