HDF5 2.0.0 updates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_lib_state, along with new context state
brtnfld
commented
Nov 14, 2024
| if (H5VLstart_lib_state() < 0) { | ||
| fprintf(fout_g, " [ ABT ERROR] %s H5VLstart_lib_state failed\n", __func__); | ||
| if (H5VLOPEN_LIB_CONTEXT(&task->h5_context) < 0) { | ||
| fprintf(fout_g, " [ ABT ERROR] %s %s failed\n", __func__, FUNC_H5VLOPEN_LIB_CONTEXT); | ||
| goto done; | ||
| } |
There was a problem hiding this comment.
This pattern of changes is repeated for the other 2.0 changes.
brtnfld
commented
Nov 14, 2024
| if (is_lib_state_restored && H5VLfinish_lib_state() < 0) | ||
| fprintf(fout_g, " [ ABT ERROR] %s H5VLfinish_lib_state failed\n", __func__); | ||
| if (is_lib_state_restored && H5VLCLOSE_LIB_CONTEXT(task->h5_context) < 0) | ||
| fprintf(fout_g, " [ ABT ERROR] %s %s failed\n", __func__, FUNC_H5VLCLOSE_LIB_CONTEXT); | ||
| if (NULL != task->h5_state && H5VLfree_lib_state(task->h5_state) < 0) |
There was a problem hiding this comment.
This pattern of changes is repeated for the other 2.0 changes.
brtnfld
commented
Nov 14, 2024
houjun
approved these changes
Nov 14, 2024
jhendersonHDF
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDF5 2.0.0 API updates, including the renaming of H5VLstart_lib_state and H5VLfinish_lib_state, along with a new context state.