Upgrade SpringBoot 2 to SpringBoot 3 (javax -> jakarta) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contain attributes (getAttributes() = null)
# Conflicts: # hhn-helpdesk-backend/pom.xml
rzo1
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Hi @Snorzze
thanks for the pull-request. I have added some comments / suggestions.
- What do you think about adding a GitHub actions workflow to automatically test the (Java-related) changes? We can also add it at a later point
- Currently, the unit tests are failing if the project is build locally. I guess, it needs some adjustments for the Spring-Test Context to exclude OIDC-related beans from discovery.
hhn-helpdesk-backend/src/main/java/de/hhn/rz/rest/UserInfoEndpoint.java
Outdated
Show resolved
Hide resolved
hhn-helpdesk-backend/src/main/java/de/hhn/rz/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
hhn-helpdesk-backend/src/main/java/de/hhn/rz/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
hhn-helpdesk-backend/src/main/java/de/hhn/rz/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
hhn-helpdesk-backend/src/main/java/de/hhn/rz/services/AuditLogService.java
Outdated
Show resolved
Hide resolved
hhn-helpdesk-backend/src/test/java/de/hhn/rz/utilities/HibernateUtil.java
Show resolved
Hide resolved
|
I will do a step-by-step testing of the |
|
Tests are fine now. GH actions proof ;-) |
|
Ready to merge @rzo1 please test |
rzo1
changed the title
rzo1
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Upgrade from Spring Boot 2 --> 3.
Currently, WIP because README with instructions is not finished yet (testing needed). But the upgrade is done.
Important
When deploying this, all generated password letters will be invalidated because of the security bug fixed earlier.