Add secureProxy option to the cookie session #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into kw-display-reports
…into kw-display-reports
…into kw-display-reports
…eam/Head-Start-TTADP into kw-display-reports
…d-Start-TTADP into kw-display-reports
…into kw-display-reports
…into kw-display-reports
…d-Start-TTADP into kw-display-reports
…Start-TTADP into kw-secure-cookie
Add explicit cookie-session options
Display reports
To eliminate `Call retries were exceeded` error for frontend tests Add --maxWorkers=50% as suggested at jestjs/jest#8769
…tests Try limiting workers for frontend tests
Extend yarn commands and add resources for backend
rahearn
requested changes
Feb 16, 2021
src/app.js
Outdated
| @@ -29,6 +29,7 @@ app.use(cookieSession({ | |||
|
|
|||
| // Cookie Options. httpOnly is set by default to true for https | |||
| sameSite: 'lax', | |||
| secureProxy: true, | |||
There was a problem hiding this comment.
This looks great in dev, but seems to be breaking cookies in my local environment, preventing any logins when BYPASS_AUTH is false.
Suggested change
| secureProxy: true, | |
| secureProxy: (process.env.NODE_ENV === 'production'), |
| @@ -0,0 +1,25 @@ | |||
| # TTADP Backend | |||
|
Thanks for finding this. Created adhocteam#174 since I wasn't able to commit the suggested change here. |
Make secureProxy setting conditional
rahearn
approved these changes
Feb 16, 2021
rahearn
pushed a commit
that referenced
this pull request
May 26, 2021
[TTAHUB-121]: Create ADR for using New Relic for web analytics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Small change to add explicit option to the cookie used for session management.
plus the changes for issue 5
How to test
Issue(s)
Checklist