Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployed UI frontend issues (#39) #70

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix deployed UI frontend issues (#39) #70

merged 1 commit into from
Sep 30, 2020

Conversation

jasalisbury
Copy link
Contributor

Description of change

  • Serve the static frontend before applying the auth middleware
  • The CSP of the backend (via helmet) forces us to set INLINE_RUNTIME_CHUNK to false.

How to test

  1. Login to the sandbox env https://tta-smarthub-sandbox.app.cloud.gov/

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

@jasalisbury
Fix deployed UI frontend issues (#39)
7b0a274 
* Fix deployed UI frontend issues

 * Serve the static frontend before applying the auth middleware
 * The CSP of the backend forces us to set INLINE_RUNTIME_CHUNK to
false. See https://create-react-app.dev/docs/advanced-configuration/

* Set sandbox branch to this branch

* Rename tests to match what they test
rahearn
rahearn approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@rahearn rahearn merged commit a44a74d into HHS:main Sep 30, 2020
rahearn pushed a commit that referenced this pull request Nov 23, 2020
@SarahJaine
init sandbox tf env (#70)
337e58b 
Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
rahearn added a commit that referenced this pull request Nov 23, 2020
@rahearn
Merge branch 'main' into circleci-export
31e4ed9 
* main: (38 commits)
  CD: Bind RDS instance (#71)
  Update test
  init sandbox tf env (#70)
  Remove comments
  Update tests
  Update tests
  Update tests
  Add constants; other changes
  Remove unused import
  Remove placeholder and unnecessary fragment
  Remove max workers
  Add deletions after each test
  Remove comment
  Update api doc
  Add user admin validation
  Add forgotten change
  Create the admin API doc
  Set sandbox branch
  Add multiselect component
  Update the erd diagram
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahearn rahearn rahearn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasalisbury @rahearn