[ci] Remove python 3.7 runners from test workflow. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for python>3.8 currently fail because of numpy 2.0, see #618. |
.github/workflows/test.yml
Outdated
| @@ -23,17 +23,13 @@ jobs: | |||
| - macos-latest | |||
| - windows-latest | |||
| python-version: | |||
| - '3.7' | |||
| - '3.8' | |||
There was a problem hiding this comment.
Suggested change
| - '3.8' |
There was a problem hiding this comment.
I think after merging #618 python 3.8 should still work with numpy<2.0 as the changes are backward compatible. But as python 3.8 will be obsolete soon I'm fine with removing it from the ci right away. I will push an update soon.
There was a problem hiding this comment.
On top of removing python 3.8 I now also added python 3.12.
There was a problem hiding this comment.
Makes sense, thanks for the explanation!
agriyakhetarpal
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Python 3.7 from the CI as it reached it's end of life a year ago (and not all runners are still available in Github Actions). Python 3.8 will reached its EOL in three months so I would propose to support it until then.