Fix encoded values map attribute #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to include possible future/test set sample values. Refactored docstring
The unique logger is 'root' logging instance. This avoids the creation of multiple logging instances for each module For future reference we could create a custom logger with the same name and this custom logger is called with the same name by each module
|
This pull request introduces 1 alert when merging 94d4f43 into 82871fe - view on LGTM.com new alerts:
|
Refactored docstrings
The changes should make the code flow more readable
|
-1.2% coverage is too much (we have the threshold set at -1%).. can you test something at least? 🙏🏽 |
|
This pull request introduces 1 alert when merging 9b7c600 into 82871fe - view on LGTM.com new alerts:
|
The tested func is "split_continuous_column_into_bins"
alessiamarcolini
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.encoded_values_mapinitializationrootLogger instance. This avoids the creation of multiple logging instances for each module. (see issue Create a custom Logger instance instead of usingrootone #104 for a possible future improvement of this)printcalls withlogging.info