Tests and minor fixes for "anonymize_database.anonymize_data" function #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mocks Added test_med_exam_col_list, test_least_nan_cols, test_contains_duplicated_features, test_show_columns_type for the related dataframewithinfo methods
….ONEHOT (to exploit the Enum that gathers the supported functions for encoding. Added tests for "get_enc_column_from_original" and "get_original_from_enc_column" methods Added a FeatureOperation to df_info_with_operations fixture
…s to EncodingFunctions.ONEHOT.value() , which is actually an instance since it should be the actual encoder instance used to encode the feature
…Frame Moved some tests inside Describe_DataFraneWithInfo class Added tests for add_operation and find_operation_in_column methods Added fixture for creating a DataFrameWithInfo instance with previous FeatureOperation instances (already added to be found)
….ONEHOT (to exploit the Enum that gathers the supported functions for encoding. Added tests for "get_enc_column_from_original" and "get_original_from_enc_column" methods Added a FeatureOperation to df_info_with_operations fixture
…s to EncodingFunctions.ONEHOT.value() , which is actually an instance since it should be the actual encoder instance used to encode the feature
Added a new error exception "NotShelveFileError" to handle the case where the filename is not a file created by using shelve module. Fixed isinstance typo
…eWithInfo instances. Added two fixtures for creating generic files with 'shelve' module and the builtin functions. Fixed tests after rebase.
… in the column instead of the first one only.
… fixture that may be useful to multiple test scripts
…" function. Added and reformatted all the comments. Modified code to drop duplicates in DataFrame (function "create_private_info_db"). Fixes undefined "df_sani" variable with the correct variable.
Added DataFrame mock "df_with_private_info" for creating a df with some private columns and other data columns
lorenz-gorini
force-pushed
the
test_anonymize_database
branch
from
a7ba5f8 to
1df8074
Compare
alessiamarcolini
suggested changes
Aug 27, 2020
alessiamarcolini
suggested changes
Aug 27, 2020
alessiamarcolini
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"anonymize_database.anonymize_data" function fixes:
Tests: