Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Webpack v5 #4778

Draft
wants to merge 10 commits into
base: v3
Choose a base branch
from
Draft

switch to Webpack v5 #4778

wants to merge 10 commits into from

Conversation

derhuerst
Copy link
Member

@derhuerst derhuerst commented Mar 24, 2023

This PR includes the changes of and depends on PR #4777; Please review & merge that one first.

Proposed Changes

  • upgrade to Webpack & Webpack CLI v5, adapt config according to the migration guide (some things left to do)
  • upgrade to webpack-dev-server v4
  • upgrade plugins: {favicons,optimize-css-assets,terser}-webpack-plugin, webpack-assets-manifest, webpack-bundle-analyzer
  • convert all files (transitively) imported by webpack.config.babel.js (and thus by app/configurations/config.*.js) to pure ESM, instead of an ESM/CJS mix as before (still some work to do)

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors – didn't thoroughly check yet
  • Changes are documented or they are self explanatory
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

(This is the upstream equivalent of embarkokc#24.)

@derhuerst derhuerst requested a review from vesameskanen March 24, 2023 13:31
@derhuerst derhuerst force-pushed the webpack5-upstream branch from 8599b31 to b8d7cba Compare June 23, 2023 10:56
@vesameskanen vesameskanen changed the base branch from v3 to DT-6044 October 11, 2023 09:34
@vesameskanen vesameskanen changed the base branch from DT-6044 to v3 October 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants