Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-5927 Search field accessibility #4878

Merged
merged 3 commits into from
Nov 2, 2023
Merged

DT-5927 Search field accessibility #4878

merged 3 commits into from
Nov 2, 2023

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Nov 2, 2023

Proposed Changes

  • Instructions for using the tab key to navigate the search fields.
  • Instructions about the focus moving automatically from the origin field to the destination field.
  • Simple aria label identifying the search fields added to an upper div so that Chrome users can also detect the search fields while using arrow keys.
  • component version updates

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@sharhio sharhio changed the title Dt 5927 DT-5927 Search field accessibility Nov 2, 2023
@vesameskanen vesameskanen merged commit 8cb1f77 into v3 Nov 2, 2023
5 checks passed
@vesameskanen vesameskanen deleted the DT-5927 branch November 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesameskanen vesameskanen vesameskanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharhio @vesameskanen