chore: configure digitraffic vehicle realtime #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optionsome
reviewed
Nov 24, 2023
app/util/mqttClient.js
Outdated
Comment on lines
139
to
145
| // If a general topic is returned, at least limit it to instances feed ids | ||
| if (topics[0] === '/gtfsrt/vp/+/+/+/+/+/+/+/+/+/+/+/+/+/+/+/#') { | ||
| const { feedIds } = actionContext.config; | ||
| topics = feedIds.map( | ||
| feedId => `/gtfsrt/vp/${feedId}/+/+/+/+/+/+/+/+/+/+/+/+/+/+/#`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
This topic code is a bit too specific to this one MQTT broker. Couldn't it be possible to somehow define in the Map.js startClient that we should subscribe to these topics?
|
I don't know if these are somehow already disabled for kela but I think we should disable vehicle showing there if it already isn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull Request Check List
Review