Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better validation for alerts #5197

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Better validation for alerts #5197

merged 9 commits into from
Dec 12, 2024

Conversation

vesameskanen
Copy link
Member

  • Alerts from past legs ignored
  • Transfer alerts from past transfers ignored
  • No transfer alert if user has reached the departure stop

@vesameskanen vesameskanen marked this pull request as draft December 12, 2024 05:30
@vesameskanen vesameskanen marked this pull request as ready for review December 12, 2024 13:45
partisaani
partisaani approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@partisaani partisaani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@partisaani partisaani merged commit 805e0e1 into v3 Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partisaani partisaani partisaani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vesameskanen @partisaani