Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collection to response context #59

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

raoashish10
Copy link

@raoashish10 raoashish10 commented Oct 14, 2020

Regarding #57

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

So I have added the code and adds the Collection keyword in the context of the response but I am not sure about the code ie. I am not sure if the position of the code is apt and if this was the fix that was needed. So please guide me and let me know if there are mistakes.

Change logs

Added

  • Added Collection keyword in the response context generated.

@Mec-iS Mec-iS requested a review from farazkhanfk7 May 24, 2021 16:34
@Mec-iS
Copy link
Contributor

Mec-iS commented May 31, 2021

@farazkhanfk7 do you think this is still useful?

@farazkhanfk7
Copy link
Member

farazkhanfk7 commented Jun 1, 2021

yes we can still add this. But I think it should be collections. Also this is only a single line change but we'll also have to update tests and add these changes in Context class of doc_writer.py.

@Mec-iS Mec-iS added enhancement New feature or request GSOC-2021 labels Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GSOC-2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants