Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS 2020 queries #1577

Merged
merged 32 commits into from
Dec 7, 2020
Merged

CSS 2020 queries #1577

merged 32 commits into from
Dec 7, 2020

Conversation

LeaVerou
Copy link
Member

@LeaVerou LeaVerou commented Nov 25, 2020 •
edited by rviscomi
Loading

Progress on #898

@rviscomi rviscomi added analysis Querying the dataset ASAP This issue is blocking progress labels Nov 25, 2020
@rviscomi rviscomi added this to the 2020 Analysis milestone Nov 25, 2020
@LeaVerou
Add query for all Blink Features
f2921af 
For @supports and a number of other things
@LeaVerou
Copy link
Member Author

I also just added a query for all Blink features. Quite enlightening results! I wonder if it would be best to use those numbers instead of the Rework ones for the metrics that could be served by those.

@rviscomi rviscomi changed the title Add queries for all functions and all properties CSS 2020 queries Nov 29, 2020
rviscomi
rviscomi requested changes Nov 30, 2020
View reviewed changes
sql/2020/01_CSS/all_features.sql Outdated Show resolved Hide resolved
sql/2020/01_CSS/vendor_prefix_summary.sql Outdated Show resolved Hide resolved
sql/2020/01_CSS/vendor_prefix_summary.sql Outdated Show resolved Hide resolved
@LeaVerou
Copy link
Member Author

LeaVerou commented Dec 1, 2020 •
edited
Loading

@rviscomi I just pushed repetition.sql, could you please take a look before I run it on parsed_css? It seems to return reasonable results on parsed_css_1k

rviscomi
rviscomi requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repetition.sql LGTM, nice work

Just a couple of outstanding comments, then this is good to go

sql/2020/01_CSS/all_features.sql Outdated Show resolved Hide resolved
sql/2020/01_CSS/vendor_prefix_summary.sql Outdated Show resolved Hide resolved
@LeaVerou
Copy link
Member Author

LeaVerou commented Dec 3, 2020

Done!

@rviscomi rviscomi merged commit b269c2e into main Dec 7, 2020
@rviscomi rviscomi deleted the css-sql-2020 branch December 7, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees

@LeaVerou LeaVerou

Labels
analysis Querying the dataset ASAP This issue is blocking progress
Projects
None yet
Milestone
2020 Analysis
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaVerou @rviscomi