Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression 2020 edits #1688

Merged
merged 12 commits into from
Dec 9, 2020
Merged

Compression 2020 edits #1688

merged 12 commits into from
Dec 9, 2020

Conversation

exterkamp
Copy link
Contributor

@exterkamp exterkamp commented Dec 9, 2020 •
edited
Loading

Progress on #916 #1432 cc @mo271

Major changes:

  • Moving image compression figures to What type of content should we compress? section.
  • Moved the Recommended compression levels to use. figure inside the paragraph referencing it.
  • Moved the Adoption of compression algorithms. into the Current state of HTTP compression section.

Editors notes:

  • Spell Check + Basics
    • Spellcheck
    • it's/its
    • Oxford Commas
    • Replace Quotes
    • Acronyms
    • Write out #'s < 10
  • Markdown fixes
    • Merge paragraphs into 1 line
    • Code format technical terms
    • No inline styles
    • Format tables
  • 1st round edits + TODOs
  • Check Headings
  • Conclusion exists
  • Check Links
    • Internal
    • Make more Internal links?
    • External
  • Check graphics and Figures Figures Guide
  • Chapter Metadata ✅
  • Maybe add new quote callouts
  • Edits, round 2
  • Final spellcheck
  • Check print layout

@exterkamp exterkamp mentioned this pull request Dec 9, 2020
Closed
22 tasks
@exterkamp exterkamp changed the title Compression 2020 Edits Compression 2020 edits Dec 9, 2020
@rviscomi rviscomi added the editing Content excellence label Dec 9, 2020
@rviscomi rviscomi added this to the 2020 Content Writing milestone Dec 9, 2020
@rviscomi rviscomi requested a review from mo271 December 9, 2020 06:39
exterkamp
exterkamp commented Dec 9, 2020
View reviewed changes
src/content/en/2020/compression.md Outdated

## Current state of HTTP compression

{# TODO(authors): The below graph would imply that this should be "no" compression, reversing the meaning. Is that accurate? #}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo271

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get the question, but the text seems to be accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should be more explicit.

The old text said "Approximately 60% of HTTP responses are delivered with text-based compression." But the data table below had the exact opposite data in it. So I changed that text by adding the "no".

We should be good now. I'll delete the TODO.

src/content/en/2020/compression.md Outdated Show resolved Hide resolved
src/content/en/2020/compression.md Outdated Show resolved Hide resolved
src/content/en/2020/compression.md

{# TODO(authors): Should this x-axis be labeled "Number of Requests"? Should it be more like "Percent of `enable-text-compression` scores"? #}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo271

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this would be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have edit access to the sheets, so you/analysts might need to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the chart and I'll be committing the screenshot change to this PR as well

src/content/en/2020/compression.md Outdated Show resolved Hide resolved
@exterkamp exterkamp marked this pull request as ready for review December 9, 2020 08:26
@exterkamp exterkamp requested a review from mo271 December 9, 2020 08:26
@mo271
Update compression.md
1fa3fa1 
one more format for Jyrki's bio
mo271
mo271 approved these changes Dec 9, 2020
View reviewed changes
src/content/en/2020/compression.md Outdated

## Current state of HTTP compression

{# TODO(authors): The below graph would imply that this should be "no" compression, reversing the meaning. Is that accurate? #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get the question, but the text seems to be accurate.

src/content/en/2020/compression.md Outdated Show resolved Hide resolved
src/content/en/2020/compression.md Outdated Show resolved Hide resolved
src/content/en/2020/compression.md

{# TODO(authors): Should this x-axis be labeled "Number of Requests"? Should it be more like "Percent of `enable-text-compression` scores"? #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this would be better.

@rviscomi
Copy link
Member

rviscomi commented Dec 9, 2020

As this edit is still ongoing we're going to launch without it (in about an hour) but there are some good suggestions/improvements in here so we can get this out in the following release.

@exterkamp
Copy link
Contributor Author

@rviscomi major edits are done.

There is still 1 TODO left for chart editing, but it is minor, and it matches 2019's charts, but I also think those should be changed imo.

@exterkamp exterkamp requested a review from rviscomi December 9, 2020 19:50
rviscomi
rviscomi approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exterkamp and @mo271! I can handle the chart update and merge.

src/content/en/2020/compression.md

{# TODO(authors): Should this x-axis be labeled "Number of Requests"? Should it be more like "Percent of `enable-text-compression` scores"? #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the chart and I'll be committing the screenshot change to this PR as well

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 41.3%, saving 30.16 KB.

Filename Before After Improvement Visual comparison
src/static/images/2020/compression/text-compression-lighthouse-scores.png 73.01 KB 42.85 KB -41.3% View diff

690 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@rviscomi rviscomi merged commit f524495 into main Dec 9, 2020
@rviscomi rviscomi deleted the compression-edits branch December 9, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo271 mo271 mo271 approved these changes

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
editing Content excellence
Projects
None yet
Milestone
2020 Content Writing
Development

Successfully merging this pull request may close these issues.
4 participants
@exterkamp @rviscomi @mo271 @tunetheweb