Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third Party 2021 Queries #2355

Merged
merged 27 commits into from
Oct 21, 2021
Merged

Third Party 2021 Queries #2355

merged 27 commits into from
Oct 21, 2021

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Oct 3, 2021 •
edited
Loading

Makes progress on #2145

  • Conversion of 2020 Third Party Queries
  • Add new query looking at number of third parties by rank
  • Add @housseindjirdeh 's first paint blocking query
  • Deep dive on popular, known slow/weighty third-parties (YouTube embed, Twitter embeds)?

@tunetheweb tunetheweb added the analysis Querying the dataset label Oct 3, 2021
@tunetheweb tunetheweb added this to the 2021 Analysis milestone Oct 3, 2021
@tunetheweb tunetheweb mentioned this pull request Oct 3, 2021
Closed
6 tasks
@rviscomi rviscomi added the ASAP This issue is blocking progress label Oct 12, 2021
@rviscomi
Copy link
Member

@tunetheweb are all of the queries in this PR so far just carry-overs from 2020? Anything I can do to help unblock the remaining queries?

@tunetheweb tunetheweb marked this pull request as ready for review October 17, 2021 19:03
@tunetheweb
Copy link
Member Author

All queries run, and visualisations added and available in the sheet: https://docs.google.com/spreadsheets/d/1tf4RMF8SYr6he9tbqt61yuFJ_QK-F-i7XPxaPkpKSDI/

This PR is ready for review.

@tunetheweb tunetheweb requested a review from a team October 17, 2021 19:04
@tunetheweb tunetheweb changed the title Third-Party 2021 Queries Third Party 2021 Queries Oct 18, 2021
rviscomi
rviscomi requested changes Oct 20, 2021
View reviewed changes
sql/2021/third-parties/distribution_of_3XX_response_body_size.sql Show resolved Hide resolved
sql/2021/third-parties/distribution_of_3XX_response_body_size.sql Show resolved Hide resolved
sql/2021/third-parties/distribution_of_3XX_response_body_size.sql Outdated Show resolved Hide resolved
sql/2021/third-parties/distribution_of_3XX_response_body_size.sql Outdated Show resolved Hide resolved
sql/2021/third-parties/percent_of_third_party_cache.sql Show resolved Hide resolved
sql/2021/third-parties/tao_by_third_party.sql Outdated Show resolved Hide resolved
sql/2021/third-parties/third_parties_blocking_main_thread_percentiles.sql Show resolved Hide resolved
sql/2021/third-parties/third_parties_blocking_rendering.sql Show resolved Hide resolved
sql/2021/third-parties/third_parties_blocking_rendering_percentiles.sql Show resolved Hide resolved
sql/2021/third-parties/top100_third_parties_by_number_of_websites.sql Outdated Show resolved Hide resolved
tunetheweb and others added 8 commits October 21, 2021 00:25
@tunetheweb tunetheweb requested a review from rviscomi October 21, 2021 00:43
@tunetheweb tunetheweb merged commit 0d868fb into main Oct 21, 2021
@tunetheweb tunetheweb deleted the third-parties-2021-queries branch October 21, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees

@tunetheweb tunetheweb

Labels
analysis Querying the dataset ASAP This issue is blocking progress
Projects
None yet
Milestone
2021 Analysis
Development

Successfully merging this pull request may close these issues.
2 participants
@tunetheweb @rviscomi