Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party 2021 query amends #2404

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Third party 2021 query amends #2404

merged 6 commits into from
Oct 25, 2021

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Oct 24, 2021 •
edited
Loading

Makes progress on #2145

Small tweaks to third-party queries as chapter is written.

  • Restrict queries to resources used in at least 50 sites (done in 2019, but not in 2020).
  • Add some more percentile queries
  • Change main thread blocking to only look at 250ms or above

@tunetheweb tunetheweb added the analysis Querying the dataset label Oct 24, 2021
@tunetheweb tunetheweb added this to the 2021 Analysis milestone Oct 24, 2021
@tunetheweb tunetheweb self-assigned this Oct 24, 2021
@tunetheweb tunetheweb marked this pull request as ready for review October 25, 2021 12:22
@tunetheweb tunetheweb requested a review from a team October 25, 2021 12:22
@rviscomi rviscomi merged commit 33ad00f into main Oct 25, 2021
@rviscomi rviscomi deleted the third-party-2021-query-amends branch October 25, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees

@tunetheweb tunetheweb

Labels
analysis Querying the dataset
Projects
None yet
Milestone
2021 Analysis
Development

Successfully merging this pull request may close these issues.
2 participants
@tunetheweb @rviscomi