2021 CSS chapter #2506
Merged
2021 CSS chapter #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrected some errors in figure construction around image weight and counts. I hope I didn’t introduce more errors!
rviscomi
requested changes
Nov 15, 2021
rviscomi
requested changes
Nov 15, 2021
rviscomi
reviewed
Nov 15, 2021
Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
Second half still to come (need to go through and find my favorite bits).
rviscomi
reviewed
Nov 15, 2021
Co-authored-by: Rick Viscomi <[email protected]>
I hope the quote isn’t too spicy!
I decided to skip spicy for summarizing.
Lines 657-663 and 940-946
|
This PR says there’s a change request to be dealt with, but I don’t see where to resolve it. Point me in the right direction and I’ll clear whatever blocker I can! |
|
Ah I had just fixed the merge conflict. I'm ok to close #2480 and merge this PR to proceed to the editing stage. |
rviscomi
approved these changes
Nov 16, 2021
Wow didn't realise it was that close! Awesome!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #2140
Also corrected some errors in figure construction around image weight and counts. I hope I didn’t introduce more errors!
Staged URL: https://20211115t173622-dot-webalmanac.uk.r.appspot.com/en/2021/css