-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits for JavaScript 2021 chapter #2614
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 29.9%, saving 457.56 KB.
1364 images did not require optimisation. |
…c.httparchive.org into javascript-2021-edits
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 27.3%, saving 16.20 KB.
1387 images did not require optimisation. |
…c.httparchive.org into javascript-2021-edits
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 27.7%, saving 268.62 KB.
1379 images did not require optimisation. |
…c.httparchive.org into javascript-2021-edits
@NishuGoel I've finished my editing pass. I made some substantial edits to the text so please give it a close read and let me know if you disagree with any changes. The staging link has also been updated with the latest version. We'll wait for your LGTM before merging. Thanks for all of your hard work on this chapter, it came out really good and I'm excited to see it go live tomorrow! 🚀 |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 28.2%, saving 15.95 KB.
1387 images did not require optimisation. |
read it through, the rephrasing seems fair to me, doesn't change the point that was being conveyed originally. (I just lost the "performance-nerd" phrase after editing, which I really liked :P) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spellcheck
Let's ship it, thanks so much for an excellent job @NishuGoel! 🚀 |
Awesome! 🚀 Thanks @rviscomi |
Progress on #2525
Closes #2141
Stage link: https://20211130t141809-dot-webalmanac.uk.r.appspot.com/en/2021/javascript
Basic edits and some TODOs for the author to review