Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits for JavaScript 2021 chapter #2614

Merged
merged 23 commits into from
Dec 1, 2021
Merged

Edits for JavaScript 2021 chapter #2614

merged 23 commits into from
Dec 1, 2021

Conversation

shantsis
Copy link
Contributor

@shantsis shantsis commented Nov 29, 2021

Progress on #2525
Closes #2141

Stage link: https://20211130t141809-dot-webalmanac.uk.r.appspot.com/en/2021/javascript

Basic edits and some TODOs for the author to review

@shantsis shantsis added the editing Content excellence label Nov 29, 2021
@shantsis shantsis added this to the 2021 Launch 🚀 milestone Nov 29, 2021
@rviscomi rviscomi self-assigned this Nov 30, 2021
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 29.9%, saving 457.56 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/javascript/ajax_beacon.png 52.74 KB 37.68 KB -28.6% View diff
src/static/images/2021/javascript/ajax_fetch.png 49.84 KB 38.10 KB -23.6% View diff
src/static/images/2021/javascript/ajax_xhr.png 51.49 KB 38.18 KB -25.8% View diff
src/static/images/2021/javascript/ajax-apis-per-year.png 61.24 KB 43.82 KB -28.4% View diff
src/static/images/2021/javascript/async-requests-per-page.png 57.13 KB 41.22 KB -27.9% View diff
src/static/images/2021/javascript/average-unminified-js-bytes.png 52.39 KB 37.25 KB -28.9% View diff
src/static/images/2021/javascript/compression-first-third-party.png 75.92 KB 52.75 KB -30.5% View diff
src/static/images/2021/javascript/compression-requests.png 74.87 KB 51.74 KB -30.9% View diff
src/static/images/2021/javascript/javascript-bytes-per-page.png 63.50 KB 45.80 KB -27.9% View diff
src/static/images/2021/javascript/javascript-resource-hint-usage.png 65.79 KB 45.75 KB -30.5% View diff
src/static/images/2021/javascript/js-libs-frameworks.png 96.49 KB 56.40 KB -41.6% View diff
src/static/images/2021/javascript/js-requests-desktop-host.png 63.56 KB 45.61 KB -28.2% View diff
src/static/images/2021/javascript/js-requests-mobile-host.png 64.23 KB 46.02 KB -28.3% View diff
src/static/images/2021/javascript/js-requests-per-page.png 62.47 KB 45.56 KB -27.1% View diff
src/static/images/2021/javascript/js-resources-over-years.png 64.47 KB 46.64 KB -27.7% View diff
src/static/images/2021/javascript/prefetch-hints-per-page.png 50.32 KB 37.07 KB -26.3% View diff
src/static/images/2021/javascript/preload-hints-per-page.png 48.53 KB 36.61 KB -24.6% View diff
src/static/images/2021/javascript/uncompressed-first-third-party.png 69.90 KB 46.79 KB -33.1% View diff
src/static/images/2021/javascript/unminified-js-audit-scores.png 76.59 KB 51.83 KB -32.3% View diff
src/static/images/2021/javascript/unminified-js-bytes.png 65.75 KB 42.71 KB -35.0% View diff
src/static/images/2021/javascript/unused-javascript-bytes-per-page.png 52.51 KB 38.14 KB -27.4% View diff
src/static/images/2021/javascript/unused-vs-total-javascript.png 70.09 KB 49.23 KB -29.8% View diff
src/static/images/2021/javascript/usage-sync-async-over-years.png 71.62 KB 49.88 KB -30.4% View diff
src/static/images/2021/javascript/usage-sync-async.png 67.38 KB 46.50 KB -31.0% View diff

1364 images did not require optimisation.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 27.3%, saving 16.20 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/javascript/js-resources-over-years.png 59.36 KB 43.17 KB -27.3% View diff

1387 images did not require optimisation.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 27.7%, saving 268.62 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/compression/compression-levels-gzip.png 62.80 KB 46.87 KB -25.4% View diff
src/static/images/2021/compression/content-encoding.png 396.63 KB 310.37 KB -21.7% View diff
src/static/images/2021/javascript/compression-first-third-party.png 68.65 KB 48.12 KB -29.9% View diff
src/static/images/2021/javascript/compression-requests.png 69.40 KB 48.30 KB -30.4% View diff
src/static/images/2021/javascript/javascript-resource-hint-usage.png 67.09 KB 46.65 KB -30.5% View diff
src/static/images/2021/javascript/js-libs-frameworks.png 114.11 KB 67.36 KB -41.0% View diff
src/static/images/2021/javascript/js-requests-desktop-host.png 59.31 KB 42.49 KB -28.4% View diff
src/static/images/2021/javascript/js-requests-mobile-host.png 60.58 KB 43.38 KB -28.4% View diff
src/static/images/2021/javascript/uncompressed-first-third-party.png 70.71 KB 47.13 KB -33.3% View diff

1379 images did not require optimisation.

@rviscomi rviscomi assigned NishuGoel and unassigned rviscomi Nov 30, 2021
@rviscomi
Copy link
Member

rviscomi commented Nov 30, 2021

@NishuGoel I've finished my editing pass. I made some substantial edits to the text so please give it a close read and let me know if you disagree with any changes. The staging link has also been updated with the latest version. We'll wait for your LGTM before merging.

Thanks for all of your hard work on this chapter, it came out really good and I'm excited to see it go live tomorrow! 🚀

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 28.2%, saving 15.95 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/javascript/ajax-apis-per-year.png 56.47 KB 40.51 KB -28.2% View diff

1387 images did not require optimisation.

@NishuGoel
Copy link
Member

@NishuGoel I've finished my editing pass. I made some substantial edits to the text so please give it a close read and let me know if you disagree with any changes. The staging link has also been updated with the latest version. We'll wait for your LGTM before merging.

read it through, the rephrasing seems fair to me, doesn't change the point that was being conveyed originally. (I just lost the "performance-nerd" phrase after editing, which I really liked :P)
thanks for the thorough reviews and edits/updates @rviscomi. Good to go from my end.

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spellcheck

src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
src/content/en/2021/javascript.md Outdated Show resolved Hide resolved
@rviscomi
Copy link
Member

rviscomi commented Dec 1, 2021

Let's ship it, thanks so much for an excellent job @NishuGoel! 🚀

@rviscomi rviscomi merged commit 1c5fc84 into main Dec 1, 2021
@rviscomi rviscomi deleted the javascript-2021-edits branch December 1, 2021 01:46
@NishuGoel
Copy link
Member

Let's ship it, thanks so much for an excellent job @NishuGoel! 🚀

Awesome! 🚀 Thanks @rviscomi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing Content excellence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript 2021
4 participants