Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit 2021 Caching chapter #2727

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Copyedit 2021 Caching chapter #2727

merged 4 commits into from
Dec 15, 2021

Conversation

tunetheweb
Copy link
Member

Closes #2161
Closes #2525

Staging link: https://20211214t234930-dot-webalmanac.uk.r.appspot.com/en/2021/caching

Standard enough copy edit. Many changes were:

  • Moved figures above discussion of them, as per Web Almanac style
  • Changed figure 15 to a stacked bar chart as thought it looked better as these add up to 100%
  • Added figure 17 as was a lot of discussion of first-party versus third-party but only had a first-party figure previously.

This is the last chapter to merge and keen to get this wrapped up so let me know ASAP if any major issues with this edit. If not, let's merge and launch!

@tunetheweb tunetheweb added the editing Content excellence label Dec 14, 2021
@tunetheweb tunetheweb requested a review from Zizzamia December 14, 2021 23:57
@tunetheweb
Copy link
Member Author

Any thoughts on this @Zizzamia / @jessnicolet ? Am I good to merge and release your hard work?

@Zizzamia
Copy link
Contributor

Reading :)

Copy link
Contributor

@Zizzamia Zizzamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲🚀🌕

@tunetheweb
Copy link
Member Author

Woo hoo!!!

@tunetheweb tunetheweb merged commit 662a3f6 into main Dec 15, 2021
@tunetheweb tunetheweb deleted the caching-2021-copyedit branch December 15, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing Content excellence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit 2021 chapters Caching 2021
2 participants