Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons, New Background color #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Kourchenko
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@noahbrenner noahbrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new icons and the cleaner feel with the solid background color!

A couple things:

  1. Some text is slightly harder to read, particularly the grey text near the bottom: "Questions about speedupamerica.com? Find more information here." This could be addressed by adjusting the background color, changing the font color, or giving just the text a different background color.

  2. The "View Results" button is partially covering the "Take the Test" button, even at the widest viewport width. They overlap more on narrower viewports. I'm also getting a horizontal scrollbar once the window gets narrower than about 780px. We should mix in some responsive design to avoid those overlaps and the scrollbar. That might mean some combination of scaling the images with the viewport and/or switching to aligning them vertically once the viewport is too narrow.

I had another thought and I'm curious what you would think: With the way you designed these icons, would it be easy to make SVG files instead of PNGs? If so, what would you think about using SVG on the site instead? They would almost certainly have smaller filesizes (especially after the server gzips them) and they would scale perfectly on any device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants