pkp#10359 Exposing date when editor confirmed review in API with date…

…EditorConfirmed
Hafsa-Naeem · Oct 4, 2024 · c3eca43 · c3eca43
1 parent d86f5d1
commit c3eca43
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 1 deletion.
diff --git a/classes/controllers/grid/users/reviewer/PKPReviewerGridHandler.php b/classes/controllers/grid/users/reviewer/PKPReviewerGridHandler.php
@@ -689,7 +689,10 @@ public function unconsiderReview($args, $request)
         $user = $request->getUser();
         $reviewAssignment = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_REVIEW_ASSIGNMENT);
 
-        Repo::reviewAssignment()->edit($reviewAssignment, ['considered' => ReviewAssignment::REVIEW_ASSIGNMENT_UNCONSIDERED]);
+        Repo::reviewAssignment()->edit($reviewAssignment, [
+            'considered' => ReviewAssignment::REVIEW_ASSIGNMENT_UNCONSIDERED,
+            'dateEditorConfirmed' => null
+        ]);
 
         // log the unconsider.
         $eventLog = Repo::eventLog()->newDataObject([
@@ -741,6 +744,9 @@ public function reviewRead($args, $request)
             ? ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED
             : ReviewAssignment::REVIEW_ASSIGNMENT_RECONSIDERED;
 
+        // set the date when the editor confirms the review
+        $newReviewData['dateEditorConfirmed'] = Core::getCurrentDate();
+
         if (!$reviewAssignment->getDateCompleted()) {
             // Editor completes the review.
             $newReviewData['dateConfirmed'] = $newReviewData['dateCompleted'] = Core::getCurrentDate();

diff --git a/classes/submission/maps/Schema.php b/classes/submission/maps/Schema.php
@@ -435,6 +435,8 @@ protected function getPropertyReviewAssignments(Enumerable $reviewAssignments, b
             $dateConfirmed = is_null($reviewAssignment->getDateConfirmed()) ? null : date('Y-m-d', strtotime($reviewAssignment->getDateConfirmed()));
             $dateCompleted = is_null($reviewAssignment->getDateCompleted()) ? null : date('Y-m-d', strtotime($reviewAssignment->getDateCompleted()));
             $dateAssigned = is_null($reviewAssignment->getDateAssigned()) ? null : date('Y-m-d', strtotime($reviewAssignment->getDateAssigned()));
+            $dateEditorConfirmed = is_null($reviewAssignment->getData('dateEditorConfirmed')) ? null : date('Y-m-d', strtotime($reviewAssignment->getData('dateEditorConfirmed')));
+
 
             $reviews[] = [
                 'id' => (int) $reviewAssignment->getId(),
@@ -445,6 +447,7 @@ protected function getPropertyReviewAssignments(Enumerable $reviewAssignments, b
                 'dateResponseDue' => $dateResponseDue,
                 'dateConfirmed' => $dateConfirmed,
                 'dateCompleted' => $dateCompleted,
+                'dateEditorConfirmed' =>  $dateEditorConfirmed,
                 'dateAssigned' => $dateAssigned,
                 'competingInterests' => $reviewAssignment->getCompetingInterests(),
                 'round' => (int) $reviewAssignment->getRound(),

diff --git a/classes/submission/reviewAssignment/DAO.php b/classes/submission/reviewAssignment/DAO.php
@@ -65,6 +65,7 @@ class DAO extends EntityDAO
         'step' => 'step',
         'reviewFormId' => 'review_form_id',
         'considered' => 'considered',
+        'dateEditorConfirmed' => 'date_editor_confirmed',
         'requestResent' => 'request_resent',
     ];
 

diff --git a/classes/submission/reviewAssignment/ReviewAssignment.php b/classes/submission/reviewAssignment/ReviewAssignment.php
@@ -269,6 +269,27 @@ public function setConsidered($considered)
         $this->setData('considered', $considered);
     }
 
+    /**
+     * Get the date the editor confirmed.
+     *
+     * @return string|null
+     */
+    public function getDateEditorConfirmed(): ?string
+    {
+        return $this->getData('dateEditorConfirmed');
+    }
+
+    /**
+     * Set the date the editor confirmed.
+     *
+     * @param string|null $dateEditorConfirmed
+     * @return void
+     */
+    public function setDateEditorConfirmed(?string $dateEditorConfirmed): void
+    {
+        $this->setData('dateEditorConfirmed', $dateEditorConfirmed);
+    }
+
     /**
      * Get the date the reviewer was rated.
      *

diff --git a/schemas/reviewAssignment.json b/schemas/reviewAssignment.json
@@ -43,6 +43,16 @@
 				"in:0,1,2,3"
 			]
 		},
+		"dateEditorConfirmed": {
+		"type": "string",
+		"description": "Date when the editor confirmed the review",
+		"format": "date-time",
+		"validation": [
+			"date:Y-m-d H:i:s",
+			"nullable"
+		],
+		"apiSummary": true
+		},
 		"dateAcknowledged": {
 			"type": "string",
 			"description": "Date editor was familiarized with the review",