Merge pull request #55 from HangHae-plus-2-9/dev

Remove Http checking on health check
HangHae-plus-2-9 · Oct 31, 2023 · 3f55a1b · 3f55a1b
2 parents 0ec01d8 + b7b523f
commit 3f55a1b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/modules/health-check/health-check.controller.spec.ts b/src/modules/health-check/health-check.controller.spec.ts
@@ -68,13 +68,13 @@ describe('HealthCheckController', () => {
 
   it('should run general health checks', async () => {
     // Arrange
-    const httpResult = { status: 'up' };
+    // const httpResult = { status: 'up' };
     const dbResult = { status: 'up' };
     const sampleResult = { status: 'up' };
 
-    const httpSpy = jest
-      .spyOn(mockHttp, 'pingCheck')
-      .mockResolvedValue(httpResult as unknown as HealthIndicatorResult);
+    // const httpSpy = jest
+    //   .spyOn(mockHttp, 'pingCheck')
+    //   .mockResolvedValue(httpResult as unknown as HealthIndicatorResult);
     const dbSpy = jest
       .spyOn(mockTypeOrm, 'pingCheck')
       .mockResolvedValue(dbResult as unknown as HealthIndicatorResult);
@@ -99,12 +99,13 @@ describe('HealthCheckController', () => {
 
     // Assert
     expect(healthSpy).toHaveBeenCalled();
-    expect(httpSpy).toHaveBeenCalledWith('google', 'https://google.com');
+    // expect(httpSpy).toHaveBeenCalledWith('google', 'https://google.com');
     expect(dbSpy).toHaveBeenCalledWith('database', { timeout: 300 });
     expect(sampleSpy).toHaveBeenCalledWith('sample');
     expect(result).toEqual({
       status: 'up',
-      info: [httpResult, dbResult, sampleResult],
+      info: [dbResult, sampleResult],
+      // info: [httpResult, dbResult, sampleResult],
     });
   });
 });
diff --git a/src/modules/health-check/health-check.controller.ts b/src/modules/health-check/health-check.controller.ts
@@ -23,7 +23,7 @@ export class HealthCheckController {
   @HealthCheck()
   check() {
     return this.health.check([
-      () => this.http.pingCheck('google', 'https://google.com'),
+      // () => this.http.pingCheck('google', 'https://google.com'),
       () => this.db.pingCheck('database', { timeout: 300 }),
       () => this.sampleHealthIndicator.isHealthy('sample'),
     ]);