Skip to content

Commit

Permalink
Unignore fixed tests related to URL resolving
Browse files Browse the repository at this point in the history
DEVSIX-6440
introfog committed Feb 16, 2023
1 parent 1bebcb1 commit 8b2824b
Showing 3 changed files with 3 additions and 7 deletions.
6 changes: 3 additions & 3 deletions io/src/test/java/com/itextpdf/io/util/UrlUtilTest.java
Original file line number Diff line number Diff line change
@@ -84,7 +84,7 @@ public void getFinalURLDoesNotLockFileTest() throws IOException {
// Tests, that getFinalConnection will be redirected some times for other urls, and initialUrl will be different
// from final url.
@Test
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
// Android-Ignore (TODO DEVSIX-6551 fix problem with getFinalConnection method related to SSL)
public void getFinalConnectionWhileRedirectingTest() throws IOException {
URL initialUrl = new URL("http://itextpdf.com");
URL expectedURL = new URL("https://itextpdf.com/");
@@ -104,7 +104,7 @@ public void getFinalConnectionWhileRedirectingTest() throws IOException {
// This test checks that when we pass invalid url and trying get stream related to final redirected url,exception
// would be thrown.
@Test
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
// Android-Ignore (TODO DEVSIX-6551 fix problem with getFinalConnection method related to SSL)
public void getInputStreamOfFinalConnectionThrowExceptionTest() throws IOException {
URL invalidUrl = new URL("http://itextpdf");

@@ -114,7 +114,7 @@ public void getInputStreamOfFinalConnectionThrowExceptionTest() throws IOExcepti
// This test checks that when we pass valid url and trying get stream related to final redirected url, it would
// not be null.
@Test
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
// Android-Ignore (TODO DEVSIX-6551 fix problem with getFinalConnection method related to SSL)
public void getInputStreamOfFinalConnectionTest() throws IOException {
URL initialUrl = new URL("http://itextpdf.com");
InputStream streamOfFinalConnectionOfInvalidUrl = UrlUtil.getInputStreamOfFinalConnection(initialUrl);
Original file line number Diff line number Diff line change
@@ -127,7 +127,6 @@ public void getOcspResponseWhenRootAndCheckCertIsNullTest()
}

@Test
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
public void getOcspResponseWhenUrlCertIsNullTest() {
OcspClientBouncyCastle castle = new OcspClientBouncyCastle(null);
Assert.assertThrows(ConnectException.class,
@@ -138,7 +137,6 @@ public void getOcspResponseWhenUrlCertIsNullTest() {
@LogMessages(messages = {
@LogMessage(messageTemplate = "Getting OCSP from http://asd", logLevel = LogLevelConstants.INFO),
})
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
public void incorrectUrlTest() {
OcspClientBouncyCastle castle = new OcspClientBouncyCastle(null);
Assert.assertThrows(UnknownHostException.class,
@@ -160,7 +158,6 @@ public void malformedUrlTest() {
@LogMessage(messageTemplate = "Getting OCSP from http://localhost:9000/demo/ocsp/ocsp-service", logLevel
= LogLevelConstants.INFO),
})
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
public void connectionRefusedTest() {
OcspClientBouncyCastle castle = new OcspClientBouncyCastle(null);
Assert.assertThrows(ConnectException.class,
Original file line number Diff line number Diff line change
@@ -126,7 +126,6 @@ public void literalAbsPrefix() {
}

@Test
// Android-Ignore (TODO DEVSIX-6440 fix problem with URL resolving)
public void handleAbsOnFileUris() {
Document doc = Jsoup.parse("<a href='password'>One/a><a href='/var/log/messages'>Two</a>", "file:/etc/");
String expectedUrl = "file:/etc/password";

0 comments on commit 8b2824b

Please sign in to comment.