Fix PdfTextArray#add(float) number sum logic

DEVSIX-7393
HankoZhou · Mar 2, 2023 · 9521edf · 9521edf
1 parent c4ecd12
commit 9521edf
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfTextArray.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfTextArray.java
@@ -107,6 +107,7 @@ public boolean add(float number) {
                     set(size() - 1, new PdfNumber(lastNumber));
                 } else {
                     remove(size() - 1);
+                    lastNumber = Float.NaN;
                 }
             } else {
                 lastNumber = number;

diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfTextArrayTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfTextArrayTest.java
@@ -131,4 +131,37 @@ public void addCollectionTest() {
         textArray.addAll(collection);
         Assert.assertEquals(collection.list, textArray.list);
     }
+
+    @Test
+    public void addZeroSumTest() {
+        PdfTextArray textArray = new PdfTextArray();
+        textArray.add(new PdfString("test"));
+        textArray.add(new PdfNumber(11));
+        textArray.add(new PdfNumber(12));
+        textArray.add(new PdfNumber(-13));
+        textArray.add(new PdfNumber(8));
+        textArray.add(new PdfNumber(-18));
+        textArray.add(new PdfString("test"));
+
+        PdfArray expected = new PdfArray();
+        expected.add(new PdfString("test"));
+        expected.add(new PdfString("test"));
+        Assert.assertEquals(expected.list, textArray.list);
+    }
+
+    @Test
+    public void addZeroSumAtTheBeginningTest() {
+        PdfTextArray textArray = new PdfTextArray();
+        textArray.add(new PdfNumber(11));
+        textArray.add(new PdfNumber(-11));
+        textArray.add(new PdfNumber(13));
+        textArray.add(new PdfString("test"));
+
+        PdfArray expected = new PdfArray();
+        expected.add(new PdfNumber(13));
+        expected.add(new PdfString("test"));
+        Assert.assertEquals(expected.list, textArray.list);
+    }
+
+
 }