Resolved multiple warnings on Apple targets.
#1145
Conversation
It would be better to solve the root cause of this warning, which is that hxcpp/toolchain/iphoneos-toolchain.xml Line 35 in 17ac6e8 |
|
@tobil4sk is it fine now? |
|
@MAJigsaw77 Thanks, the mac-toolchain.xml changes look good to me now |
|
@tobil4sk Are the changes from |
Tested them, they work flawlessly |
Thanks, they look good to me too |
| @@ -217,7 +217,7 @@ class PointerData : public hx::Object | |||
| String toString() | |||
| { | |||
| char buf[100]; | |||
| sprintf(buf,"Pointer(%p)", mValue); | |||
| snprintf(buf,sizeof(buf),"Pointer(%p)", mValue); | |||
There was a problem hiding this comment.
Was this correct? sizeof() returns the size of a single char, it doesn't return 100.
There was a problem hiding this comment.
Actually, it looks like in this case it does work properly since char buf[] is stack allocated. Is it also working correctly in mysql/my_api.cpp?
There was a problem hiding this comment.
Would seem like this is also the case there:
hxcpp/src/hx/libs/mysql/my_proto.h
Line 114 in 08f88ff
Should all be good then.
sprintfwithsnprintfbecausesprintfis deprecated.-Wno-unused-command-line-argumentto MacOS toolchain to remove warnings related to unused commands, for exampleclang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument].