Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added column number break functionality to hxcpp, hxcpp-debugger #466

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

tekgek
Copy link

@tekgek tekgek commented Jun 7, 2016

  • Added column number fields to code-position-related function
  • Added a nextLine function so that developers can step over an entire line of code
  • Added column number check to FindFileLineBreakpoint()

@hughsando
Copy link
Member

Sorry I have not commented on this earlier.
Is this something you are still interested in?

@EricBishton
Copy link
Member

Yes, Hugh! Very, very, much. There are accompanying changes to the compiler, but they are fairly small. Simon was waiting on those changes until he got some feedback from you on these changes.

TiVo spent a good bit of time and money getting these changes created by the UCSC team, and they allow the debugger to set breakpoints on and step between individual expressions on a single line. It's a much more granular debugging workflow.

@hughsando
Copy link
Member

I have some mixed feelings about this one.
I'm sure you are aware that there is not a 1:1 relationship between haxe and cpp code - especially at the column level. So understand better, are you looking to be able to break at the "HXDLIN" macros, rather than just the "HXLINE" macros, which only occur then the line changes value?

My main concerns are that old(ish) haxe need to work with new hxcpp, and perhaps adding complexity/speed when it is only sometimes needed. Generally hxcpp can work with multiple versions by either conditionally defining the macos, or adding new macros with different names, and adding default args to non-macro functions.

Perhaps these concerns can be overcome by a haxe define, like -D debug_columns. Turning this on would generate the extra info in the output .cpp file, and add the HXCPP_DEBUG_COLUMNS define to the compile phase. The debugger library could then also use the debug_columns condition to work out what commands are available.

@Simn Simn added this to the Later milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants