Skip to content

Commit

Permalink
Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks
Browse files Browse the repository at this point in the history
There's some logic in the filter to strip out tag changes that share a
TRIGGER block with a tag change that sets BOARD_VISUAL_STATE to 2. We
believe that for some time now, BOARD_VISUAL_STATEs 1 or 2 are related to
shop manipulation code and not part of what we want to capture in combat.

However! In a recent BGS log, there are tag changes that seem to represent
enchantments (i.e., ATK and HEALTH buffs) being applied to entities in a
BOARD_VISUAL_STATE=2 block; whereas in older BGS logs, that happens in
a separate block.

This change removes the logic that was stripping all BOARD_VISUAL_STATE=2
block tag changes.
  • Loading branch information
joolean committed Oct 25, 2024
1 parent ffc1ce7 commit 62a9ec3
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions hslog/filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ class BattlegroundsLogFilter(Iterable):
- All options messages (from DebugPrintOptions) are discarded
- Blacklisted and unknown tags for FULL_ENTITY and SHOW_ENTITY messages are discarded
- TAG_CHANGES containing blacklisted and unknown tags are discarded
- All TAG_CHANGES that are part of a TRIGGER block that include a BOARD_VISUAL_STATE=2
tag change are discarded
- All TAG_CHANGES that precede a BOARD_VISUAL_STATE=1 tag change in a TRIGGER block are
discarded
"""
Expand Down Expand Up @@ -392,9 +390,6 @@ def _handle_tag_change(self, msg: str, line: str):
buf.should_skip = True
self._current_buffer.buffer[i] = buf

if value == "2":
setattr(self._current_buffer, "skip_tag_changes", True)

return

# If we're already buffering a DEATHS block, then changing the PLAYER_TECH_LEVEL
Expand Down

0 comments on commit 62a9ec3

Please sign in to comment.