Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle network errors via translation in a DRF custom exception handler #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle network errors via translation in a DRF custom exception handler #19

wants to merge 1 commit into from

Conversation

joolean
Copy link
Contributor

@joolean joolean commented Oct 19, 2023

No description provided.

@joolean joolean force-pushed the network-error-handling branch from 3acf280 to 194dbd6 Compare October 19, 2023 22:03
@joolean joolean requested a review from beheh October 19, 2023 22:06
@beheh
Copy link
Contributor

beheh commented Oct 25, 2023

@joolean There's some commits on this branch that don't belong here. You'll need to rebase onto master.

beheh
beheh reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@beheh beheh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception handling commit looks good!

@joolean joolean force-pushed the network-error-handling branch from 194dbd6 to 7c79392 Compare October 25, 2023 20:14
@beheh beheh force-pushed the master branch 5 times, most recently from 21525ae to 3b547a7 Compare April 1, 2024 16:05
@beheh beheh force-pushed the master branch 3 times, most recently from 9c35db9 to 2a2a258 Compare April 16, 2024 22:49
@beheh beheh force-pushed the master branch 2 times, most recently from adb30ae to 2ba14ee Compare August 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beheh beheh beheh left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joolean @beheh