所有4月1日发布的版本自动视为愚人节版 #3945
Merged
所有4月1日发布的版本自动视为愚人节版 #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
为啥会编译出错…… |
|
先关了，我试试能不能 Reopen |
|
好吧不能（ |
|
……？ |
|
不是哥们咋还failing呢 |
他在别处表示，在等龙猫给他改（ |
|
这边等下 Silverteal#11 合并再合并 当然有权限直接编辑也可以 EDIT:本地测试可行性验证通过，在没有手动分类的情况下没有正式版或预览版混入，被注释处理的愚人节版本也能正确识别并加入到列表内 |
wuliaodexiaoluo
suggested changes
Jul 5, 2024
| '所有4月1日发布的版本可视为愚人节版，但不改动版本描述 | ||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | ||
| Case "04/01" | ||
| If Not Version("type") == "special" Then |
| @@ -44,6 +44,14 @@ | |||
| Version("type") = "special" | |||
| Version.Add("lore", GetMcFoolName(Version("id"))) | |||
| End Select | |||
| '所有4月1日发布的版本可视为愚人节版，但不改动版本描述 | |||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | |||
| @@ -555,6 +555,14 @@ | |||
| Version("type") = "special" | |||
| Version.Add("lore", GetMcFoolName(Version("id"))) | |||
| End Select | |||
| '所有4月1日发布的版本视为愚人节版，但不改动版本描述 | |||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | |||
| '所有4月1日发布的版本视为愚人节版，但不改动版本描述 | ||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | ||
| Case "04/01" | ||
| If Not Version("type") == "special" Then |
There was a problem hiding this comment.
单等号
要不然下次写成 is 得了
SALTWOOD
suggested changes
Jul 5, 2024
| '所有4月1日发布的版本可视为愚人节版，但不改动版本描述 | ||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | ||
| Case "04/01" | ||
| If Not Version("type") == "special" Then |
| '所有4月1日发布的版本视为愚人节版，但不改动版本描述 | ||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | ||
| Case "04/01" | ||
| If Not Version("type") == "special" Then |
| @@ -44,6 +44,14 @@ | |||
| Version("type") = "special" | |||
| Version.Add("lore", GetMcFoolName(Version("id"))) | |||
| End Select | |||
| '所有4月1日发布的版本可视为愚人节版，但不改动版本描述 | |||
| Select Case Version("releaseDate").Value(Of Date).ToString("MM'/'dd") | |||
wuliaodexiaoluo
approved these changes
Jul 12, 2024
|
|
|
修补代码 于 #4449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前的pr #3780 因为误操作被关闭了 现在重新提交