NeoForge 支持 #4045

Pigeon0v0 · 2024-06-15T13:45:23Z

本 PR 将基于先前的 Forge 安装流程，加入针对 NeoForge 的支持。
Close #2244

To-Do List:

在自动安装界面加入 NeoForge 选项，并支持显示版本列表
NeoForge 相关信息获取
版本列表相关处理（版本排序，NeoForge 相关信息显示，附加安装选项之间冲突等）
NeoForge 自动安装
NeoForge 手动安装界面
相关资源文件（图标等）补充
NeoForge 整合包安装
其他界面选项和文本补充

Known Issues:

官方源 1.20.1 列表会错误地将 47.1.82 放在第一位次（可能需要重构 Neo 相关排序）
BMCLAPI 1.20.1 列表会意外地缺失 47.1.106（我完全不知道为什么会这样...）
左侧栏图标需要绘制

3gf8jv4dv

Hex-Dragon/PCL2/actions/runs/9528843588

Preview

3gf8jv4dv · 2024-06-15T15:00:30Z

All are displayed as beta.

Preview

SALTWOOD

看代码逻辑感觉没问题，期待

3gf8jv4dv

Hex-Dragon/PCL2/actions/runs/9529017743

Preview

Pigeon0v0 · 2024-06-15T15:27:00Z

All are displayed as beta.

Fix later.

Pigeon0v0 · 2024-06-15T15:33:08Z

This comment(655364b) has not solved any problems. No need to test again. @3gf8jv4dv

I'll try to fix this later.

3gf8jv4dv · 2024-06-15T15:35:08Z

This comment(655364b) has not solved any problems. No need to test again. @3gf8jv4dv

I'll try to fix this later.

OK.

Not sure if this will be implemented in this PR (I did not see it in the To-Do List).

NeoForge 20.5 renamed mods.toml to neoforge.mods.toml.ref:

Currently only mods.toml is recognized in the main branch’s code.

Pigeon0v0 · 2024-06-15T15:49:32Z

Not sure if this will be implemented in this PR (I did not see it in the To-Do List).

NeoForge 20.5 renamed mods.toml to neoforge.mods.toml.

Currently only mods.toml is recognized in the main branch’s code.

This PR aims mainly at installing NeoForge. Related issues may be fixed another day.

Now, NeoForge client's info and name looks like the Forge client's behavior

allMagicNB · 2024-06-15T23:24:29Z

~~不知道 Forge Installer 能不能用~~

3gf8jv4dv

Now beta/stable looks like it should display normally.

feat: NeoForge 自动安装 Stage 1 fix: StdVersion 可能错误地包含了 "neoforge-" 前缀 fix: 自动安装选择 NeoForge 时自动生成的核心名称存在重复字符串

Solve a conflict

Pigeon0v0 · 2024-06-16T03:09:05Z

基本功能已经完成，剩下收个尾大概就可以合并了

手动安装这个版本列表我这里短时间搞不定，下周期末周，得等考完了再回来改

SALTWOOD · 2024-06-16T03:32:25Z

图标有哪些需要？我来帮忙（

3gf8jv4dv · 2024-06-16T03:37:23Z

图标有哪些需要？我来帮忙（

At least two are required:

The icon at 手动安装包 in the sidebar
The version list that appears after selecting NeoForge in 自动安装

Preview

SALTWOOD · 2024-06-16T03:38:21Z

图标有哪些需要？我来帮忙（

At least two are required:

The icon at 手动安装 in the sidebar

The version list that appears after selecting NeoForge in 自动安装

Preview

ok, I'm working on it.

SALTWOOD · 2024-06-16T03:43:25Z

There are three possible alternative solutions:

The version list that appears after selecting NeoForge in 自动安装

If someone has a better plan to propose

3gf8jv4dv · 2024-06-16T04:11:17Z

The UI display has some minor flaws.

1.20.1 some versions of NeoForge still show the redundant 1.20.1- prefix
The list of NeoForge versions shown in 自动安装 no longer has the prefix neoforge-, but it still shows this prefix after selecting a version

Preview

3gf8jv4dv

1.20.1 fails to install, launcher shows 404 error.

Preview

3gf8jv4dv · 2024-06-16T04:48:00Z

@SALTWOOD

HMCL and Prism Launcher currently use a variant of NeoForge branding (without the silver part around it). I personally prefer them.

Preview

bangbang93 · 2024-06-28T02:30:42Z

我觉得neoforge这个版本号规则是在给自己埋坑……你们要的话我就这两天把这个API也缓存一下好了

Pigeon0v0 · 2024-06-28T03:29:53Z

我觉得neoforge这个版本号规则是在给自己埋坑……你们要的话我就这两天把这个API也缓存一下好了

感谢（

Plain Craft Launcher 2/Pages/PageDownload/ModDownloadLib.vb

Pigeon0v0 · 2024-06-28T14:00:19Z

上面的改了

3gf8jv4dv

Three comments:

Is it possible to not show the NeoForge option when select a version <= 1.20 in Automatic Installation (自动安装)? Just like do in Manually Installation Package (手动安装包)

Current behavior
When trying to install a NeoForge modpack, the launcher started complaining again

Preview

Log (Deleted)
In Automatic Installation (自动安装), select a game version and then expand the list of NeoForge versions. Then switch to the Automatic Installation (自动安装) interface and select a different game version. There is a chance that the NeoForge version will not match correctly. An example is provided below. Note: This situation is likely to occur regardless of the source of the version list. I have never seen this happen with the Forge version list.

Preview

Log (Deleted)

bangbang93 · 2024-06-29T04:50:52Z

文档见https://bmclapidoc.bangbang93.com/#api-Neoforge-NeoforgeMavenApi
使用例

https://maven.neoforged.net/api/maven/details/releases/net/neoforged/neoforge -> https://bmclapi2.bangbang93.com/neoforge/meta/api/maven/details/releases/net/neoforged/neoforge
https://maven.neoforged.net/api/maven/details/releases/net/neoforged/forge -> https://bmclapi2.bangbang93.com/neoforge/meta/api/maven/details/releases/net/neoforged/forge

同时对应的子目录也有

https://bmclapi2.bangbang93.com/neoforge/meta/api/maven/details/releases/net/neoforged/forge/1.20.1-47.1.5

Pigeon0v0 · 2024-06-29T22:29:29Z

今天下午有空来修一下

fix: 安装 NeoForge 整合包时的参数初始化不正确 chores: 在低版本（<=1.19）的自动安装界面将不会显示 NeoForge

Pigeon0v0 · 2024-06-30T07:05:01Z

Issues mentioned by @3gf8jv4dv are resolved in 3c44a55.

Meanwhile, the version list from BMCLAPI is using the new API now, working as expected.

Feel free to test and leave comments :)

Pigeon0v0 · 2024-06-30T07:08:54Z

主楼提到的版本列表和排序的事情麻烦看一下，对我来说有点难了...

其他的功能大概是没问题

Ping @LTCatt

3gf8jv4dv · 2024-06-30T08:45:53Z

Modpacks related features appear to be working fine. Continue to catch bugs.

It seems that the following issue has been alleviated.

In Automatic Installation (自动安装), select a game version and then expand the list of NeoForge versions. Then switch to the Automatic Installation (自动安装) interface and select a different game version. There is a chance that the NeoForge version will not match correctly. An example is provided below. Note: This situation is likely to occur regardless of the source of the version list. I have never seen this happen with the Forge version list.

However, it seems that the NeoForge version list will be forced to refresh only after the Forge version list is loaded. Is there room for further optimization?

Preview

Log (Deleted).
If you first select version 1.20 and above after opening the launcher, the NeoForge option will appear as expected. When you select a version lower than 1.20 and then go back and select a version 1.20 or higher, will find that the NeoForge option disappears.

Preview

Log (Deleted).

LTCatt

#4045 (comment)
这里往后还有几条……

琢磨了一下逻辑，现在似乎没有分两次加载（获取 MC 版本列表 → 获取特定版本下的全部版本列表）的必要，直接像 OptiFine 那样加载一次就行了，这样应该能大大加快加载，并且减少 API 消耗？

Plain Craft Launcher 2/Modules/Minecraft/ModDownload.vb

3gf8jv4dv · 2024-06-30T09:23:05Z

官方源 1.20.1 列表会错误地将 47.1.82 放在第一位次（可能需要重构 Neo 相关排序）

47.1.82 seems to have been removed from NeoForged’s Maven for some reason. It is indeed available at https://maven.neoforged.net/api/maven/versions/releases/net/neoforged/forge, but not at https://maven.neoforged.net/api/maven/details/releases/net/neoforged/forge. There are also several 1.20.1 NeoForge versions with similar issues.

BMCLAPI 1.20.1 列表会意外地缺失 47.1.106（我完全不知道为什么会这样...）

https://bmclapi2.bangbang93.com/neoforge/meta/api/maven/details/releases/net/neoforged/forge can see 47.1.106, but https://bmclapi2.bangbang93.com/neoforge/list/1.20.1 not.

Pigeon0v0 · 2024-06-30T13:07:02Z

上面这俩提议我包是搞不动的...

歇一阵子再来，或者直接龙猫改了罢 Orz

Pigeon0v0 · 2024-07-01T23:38:16Z

看起来是在准备发版了，如果这次打算加上的话大概是得龙猫自己修一下了...

LTCatt · 2024-07-02T07:52:17Z

umm 还有哪些东西是没整完的，能帮忙列一下么，我到时候修了 =。=

3gf8jv4dv · 2024-07-02T08:33:51Z

@LTCatt

官方源 1.20.1 列表会错误地将 47.1.82 放在第一位次（可能需要重构 Neo 相关排序）
BMCLAPI 1.20.1 列表会意外地缺失 47.1.106（我完全不知道为什么会这样...）
左侧栏图标需要绘制

#4045 (comment)
#4045 (comment)
#4045 (comment)
#4045 (comment)
#4045 (comment)

Pigeon0v0 · 2024-07-02T08:34:01Z

侧边栏图标；一次加载获取版本列表；1.20.1 的 NeoForge 版本列表有楼上的问题（主要是 47.1.82 和 BMCLAPI 源的 47.1.106 的问题）

LTCatt · 2024-07-05T12:15:36Z

umm 能否提供使用 NeoForge 的 MCBBS 整合包以便测试？
MCBBS 似了之后都不知道搁哪找 MCBBS NeoForge 整合包……

Pigeon0v0 · 2024-07-05T13:12:46Z

NeoForge-20.4.237-HMCL.zip
NeoForge-20.4.237-BakaXL.zip

以上是我自己用其他启动器导出的...

要去找一个之前就有的包多半是有点吃力...

LTCatt · 2024-07-05T14:03:49Z

剩下的我自己做了 =。=

feat(neoforge): 添加了 NeoForge 的安装选项，并支持获取版本列表

7ba79db

Pigeon0v0 marked this pull request as draft June 15, 2024 13:46

Pigeon0v0 added the · 新功能 label Jun 15, 2024

ui: 显示 NeoForge 版本属性（测试版 / 稳定版）

e731ef6

3gf8jv4dv reviewed Jun 15, 2024

View reviewed changes

SALTWOOD reviewed Jun 15, 2024

View reviewed changes

fix: NeoForge 版本列表排序，但是抽象实现

8d9dc47

3gf8jv4dv reviewed Jun 15, 2024

View reviewed changes

fix: 一处逻辑判断错误，但未解决版本判断错误的问题

655364b

Pigeon0v0 and others added 3 commits June 15, 2024 23:57

Installer 下载和代码清理

65d21d4

optimize: version name and icon

31e391f

Now, NeoForge client's info and name looks like the Forge client's behavior

fix: 所有版本都显示为测试版 / 正式版

d8fe599

3gf8jv4dv reviewed Jun 16, 2024

View reviewed changes

Pigeon0v0 and others added 3 commits June 16, 2024 08:52

ui: 添加 NeoForge 手动安装 Tab

0e0335e

feat: NeoForge 自动安装 Stage 1 fix: StdVersion 可能错误地包含了 "neoforge-" 前缀 fix: 自动安装选择 NeoForge 时自动生成的核心名称存在重复字符串

feat: 正式支持 NeoForge 自动安装

f4b1e3e

Update PageDownloadInstall.xaml.vb

27825ed

Solve a conflict

3gf8jv4dv reviewed Jun 16, 2024

View reviewed changes

LTCatt requested changes Jun 28, 2024

View reviewed changes

chores: 代码可读性和相关优化

4dba7c9

3gf8jv4dv suggested changes Jun 28, 2024

View reviewed changes

refactor: NeoForge BMCLAPI 版本列表（爱来自 bangbang93）

3c44a55

fix: 安装 NeoForge 整合包时的参数初始化不正确 chores: 在低版本（<=1.19）的自动安装界面将不会显示 NeoForge

LTCatt requested changes Jun 30, 2024

View reviewed changes

Plain Craft Launcher 2/Modules/Minecraft/ModDownload.vb Outdated Show resolved Hide resolved

chores: 代码清理

bec5ddd

chores: 一些判断和命名修改

7921184

LTCatt merged commit 1f4d6e3 into Hex-Dragon:main Jul 5, 2024
5 checks passed

LTCatt added 完成已被处理，将在下次更新之后生效 and removed 处理中开发者正在调查或处理该项 🟥 高优先度：高 labels Jul 5, 2024

Pigeon0v0 deleted the neoforge branch July 6, 2024 01:38

3gf8jv4dv mentioned this pull request Oct 1, 2024

NeoForge 列表没有 47.1.82 #4863

Closed

1 task

NeoForge 支持 #4045

NeoForge 支持 #4045

Conversation

Pigeon0v0 commented Jun 15, 2024 • edited Loading

3gf8jv4dv left a comment

Choose a reason for hiding this comment

3gf8jv4dv commented Jun 15, 2024

SALTWOOD left a comment

Choose a reason for hiding this comment

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Pigeon0v0 commented Jun 15, 2024

Pigeon0v0 commented Jun 15, 2024 • edited Loading

3gf8jv4dv commented Jun 15, 2024 • edited Loading

Pigeon0v0 commented Jun 15, 2024

allMagicNB commented Jun 15, 2024

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Pigeon0v0 commented Jun 16, 2024

SALTWOOD commented Jun 16, 2024

3gf8jv4dv commented Jun 16, 2024 • edited Loading

SALTWOOD commented Jun 16, 2024

SALTWOOD commented Jun 16, 2024 • edited Loading

3gf8jv4dv commented Jun 16, 2024 • edited Loading

3gf8jv4dv left a comment • edited Loading

Choose a reason for hiding this comment

3gf8jv4dv commented Jun 16, 2024

bangbang93 commented Jun 28, 2024

Pigeon0v0 commented Jun 28, 2024

Pigeon0v0 commented Jun 28, 2024

3gf8jv4dv left a comment • edited Loading

Choose a reason for hiding this comment

bangbang93 commented Jun 29, 2024

Pigeon0v0 commented Jun 29, 2024

Pigeon0v0 commented Jun 30, 2024

Pigeon0v0 commented Jun 30, 2024

3gf8jv4dv commented Jun 30, 2024 • edited Loading

LTCatt left a comment

Choose a reason for hiding this comment

3gf8jv4dv commented Jun 30, 2024

Pigeon0v0 commented Jun 30, 2024

Pigeon0v0 commented Jul 1, 2024

LTCatt commented Jul 2, 2024

3gf8jv4dv commented Jul 2, 2024

Pigeon0v0 commented Jul 2, 2024

LTCatt commented Jul 5, 2024 • edited Loading

Pigeon0v0 commented Jul 5, 2024

LTCatt commented Jul 5, 2024

Pigeon0v0 commented Jun 15, 2024 •

edited

Loading

Pigeon0v0 commented Jun 15, 2024 •

edited

Loading

3gf8jv4dv commented Jun 15, 2024 •

edited

Loading

3gf8jv4dv commented Jun 16, 2024 •

edited

Loading

SALTWOOD commented Jun 16, 2024 •

edited

Loading

3gf8jv4dv commented Jun 16, 2024 •

edited

Loading

3gf8jv4dv left a comment •

edited

Loading

3gf8jv4dv left a comment •

edited

Loading

3gf8jv4dv commented Jun 30, 2024 •

edited

Loading

LTCatt commented Jul 5, 2024 •

edited

Loading