[#153] Add footer to website templates #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamshaev
changed the title
|
@fey Коля, посмотри плиз, как это выглядеть будет |
|
вроде норм @Malcom1986 если ок, мержи) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked once again overall application style and propose to improve it a little bit. Now the contrast is too high between navbar, content and footer. It's dark-light-dark now. Usually dark part only one - navbar or footer. So, I propose to make footer light. I think it will look better. By the way, this color scheme is in the file "landing.html", I just didn't implemented it fully when I did previous PR.
Current color scheme:
Proposed color scheme (from "landing.html"):
Demo: https://hexlet-correction-4.onrender.com/