Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#266] Add issue filtering by status #363

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

svmikurov
Copy link
Contributor

Add issue filtering by status to view issues.
Rename the page title "Open Issues" to "Issues".
Update navigation.

Add issue filtering by status to view issues.
Rename the page title "Open Issues" to "Issues".
Update navigation.
@svmikurov svmikurov marked this pull request as draft November 9, 2023 04:54
@svmikurov svmikurov marked this pull request as ready for review November 10, 2023 02:42
@svmikurov
Copy link
Contributor Author

@fey fey requested a review from sgmdlt November 15, 2023 10:57
@fey
Copy link
Collaborator

fey commented Nov 15, 2023

@serVmik чекните плз пайплайн - что-то упало.

По поводу формы. Не совсем понятно, что имеется ввиду в All. Тут можно подставлять пустое значение и в пплейсхотер ставить типа "статус". Тогда если инпут пустой, то будет дефолтное поведение, что мы хотим увидеть все ищщусы.
image

Rename the default value of a selection filter by status.
@svmikurov
Copy link
Contributor Author

Исправил замечание линтера.
Исправил дефолтное значение фильтра по статусу.
Демка

@fey fey merged commit c5dab57 into Hexlet:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants