Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prefer placing shellenv command in rcfile rather than shell profile on Linux #16040

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a follow-up PR for Homebrew/install#809 for document update.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @XuehaiPan! Again will wait for another @Homebrew/maintainers to 👍🏻 before I merge.

@Bo98
Copy link
Member

Bo98 commented Sep 27, 2023

(Further discussion since has been happening Homebrew/install#808 - I left a comment there)

@MikeMcQuaid
Copy link
Member

  • Inaccurate post-install instructions 

Now this was merged @XuehaiPan could you adjust this PR accordingly? Thanks!

@XuehaiPan XuehaiPan changed the title docs: prefer placing shellenv command in rcfile rather than shell profile docs: prefer placing shellenv command in rcfile rather than shell profile on Linux Oct 6, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @XuehaiPan!

@MikeMcQuaid MikeMcQuaid merged commit 8f7e06a into Homebrew:master Oct 6, 2023
28 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants