Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sslyze: deprecate #145670

Closed
wants to merge 1 commit into from
Closed

sslyze: deprecate #145670

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Sep 25, 2023
@chenrui333 chenrui333 changed the title Sslyze 5.2.0 sslyze 5.2.0 Sep 25, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2023
ZhongRuoyu
ZhongRuoyu reviewed Sep 25, 2023
View reviewed changes
Formula/s/sslyze.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 25, 2023
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 25, 2023
ZhongRuoyu
ZhongRuoyu previously approved these changes Sep 25, 2023
View reviewed changes
@chenrui333
Copy link
Member Author

test failure seen before

   COMPLIANCE AGAINST MOZILLA TLS CONFIGURATION
   --------------------------------------------
  
      Checking results against Mozilla's "MozillaTlsConfigurationEnum.OLD" configuration. See https://ssl-config.mozilla.org/ for more details.
  
      google.com:443: ERROR - Scan did not run successfully; review the scan logs above.
  Error: sslyze: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: 1

rerun the failed build

@cho-m
Copy link
Member

cho-m commented Oct 1, 2023

May be time to deprecate this. As I recall, sslyze's nassl builds copies of OpenSSL 1.0.2 (Legacy) and 1.1.1 (Modern), which seems to be where test is failing on newer Intel macOS.

@chenrui333
Copy link
Member Author

May be time to deprecate this. As I recall, sslyze's nassl builds copies of OpenSSL 1.0.2 (Legacy) and 1.1.1 (Modern), which seems to be where test is failing on newer Intel macOS.

you are right, looks upstream indeed still use openssl 1.1 stuff, just raised an issue for this, nabla-c0d3/nassl#114

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Oct 22, 2023
@chenrui333
sslyze: deprecate
9d93a02 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 changed the title sslyze 5.2.0 sslyze: deprecate Oct 22, 2023
@github-actions github-actions bot added the formula deprecated Formula deprecated label Oct 22, 2023
@chenrui333 chenrui333 requested a review from a team October 22, 2023 19:26
MikeMcQuaid
MikeMcQuaid requested changes Oct 23, 2023
View reviewed changes
Formula/s/sslyze.rb
Comment on lines +36 to +37
# upstream openssl issue report, https://github.com/nabla-c0d3/nassl/issues/114
deprecate! date: "2023-10-22", because: "Use deprecated OpenSSL 1.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off a few weeks to give upstream time to reply before deprecating, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 14, 2023
@cho-m
Copy link
Member

cho-m commented Nov 14, 2023

Closing as superseded by #152278 where sslyze was deprecated along with [email protected].

@cho-m cho-m closed this Nov 14, 2023
@cho-m cho-m added the superseded PR was replaced by another PR label Nov 14, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
@chenrui333 chenrui333 deleted the sslyze-5.2.0 branch January 22, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid requested changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu left review comments

Assignees
No one assigned
Labels
formula deprecated Formula deprecated outdated PR was locked due to age python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue stale No recent activity superseded PR was replaced by another PR upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @cho-m @MikeMcQuaid @ZhongRuoyu