Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halide 19.0.0 #201454

Merged
merged 4 commits into from
Dec 18, 2024
Merged

halide 19.0.0 #201454

merged 4 commits into from
Dec 18, 2024

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Dec 17, 2024 •
edited by daeho-ro
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.
release notes 
## Major improvements

    

  • Halide is now available for both C++ and Python usage via Pip. Try pip install halide today!
    • 

  • The Vulkan backend has matured substantially.
    • 

  • The HTML "conceptual statement" output now supports dark mode viewing.
    • 

  • For developers, CMake 3.28 is now required and we no longer require an internet connection during the build.
    • 

  • Thread pool improvements mean that workloads that do a small number of small tasks in parallel (e.g. a cheap operation applied to a small image) are up to 3x faster. If you have schedules that do not use parallelism for small inputs because you found it didn't provide any speedup, you may want to re-benchmark.
    • 

  • You can now query properties of the compiled-for target as Exprs, simplifying helper code that wants to do different things depending on the target architecture. Example: f(x) = select(target_arch_is(Target::ARM), 3, 7). Helpers include target_arch_is, target_os_is, target_has_feature, target_bits, and target_natural_vector_size. These are resolved to constants at compile-time and simplified away. Use with care, as this (intentionally) results in different behavior on different platforms.
    • 



Breaking changes


    

  • We now distribute libGenGen.a rather than GenGen.cpp.

      

    • Downstream users should link to this library with /WHOLEARCHIVE: or -Wl,--whole-archive rather than build GenGen.cpp themselves.
      • 

    • Users of the CMake package should be unaffected.
      • 

    

    • 

  • In keeping with our LLVM support policy, support for LLVM 16 has been removed.
    • 

  • We no longer use the le64/le32 generic targets for compiling runtime modules to LLVM. These targets were removed in LLVM upstream.
    • 



What's Changed


Apps and tests



Autoschedulers



Build system



CodeGen



Debugging



Documentation



Frontend



Hardware backends



LLVM



Python



Runtime



Minor bugfixes / other cleanup



New Contributors



Full Changelog: halide/Halide@v18.0.0...v19.0.0

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 17, 2024
@daeho-ro daeho-ro force-pushed the bump-halide-19.0.0 branch 2 times, most recently from 8af584e to 2c583e9 Compare December 17, 2024 02:40
@daeho-ro
Copy link
Member

Re-tagged several times for changing the github action trigger. Have to wait for a while.

@daeho-ro daeho-ro force-pushed the bump-halide-19.0.0 branch 3 times, most recently from 6fb6c41 to 2d27f5e Compare December 17, 2024 08:36
@daeho-ro daeho-ro added the help wanted Task(s) needing PRs from the community or maintainers label Dec 17, 2024
@daeho-ro
Copy link
Member

python package is not installed, it has changed a lot. 😥

@chenrui333
Copy link
Member 

  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: /home/linuxbrew/.linuxbrew/lib/libwabt.a(binary-reader.cc.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: final link failed: bad value
  collect2: error: ld returned 1 exit status

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 17, 2024
@chenrui333
Copy link
Member 

  ==> python3.13 lesson_01_basics.py
  Traceback (most recent call last):
    File "/private/tmp/halide-test-20241217-47676-qvoyah/lesson_01_basics.py", line 11, in <module>
      import halide as hl
  ModuleNotFoundError: No module named 'halide'

@chenrui333 chenrui333 mentioned this pull request Dec 17, 2024
Closed
@chenrui333 chenrui333 added upstream issue An upstream issue report is needed test failure CI fails while running the test-do block labels Dec 17, 2024
@alexreinking
Copy link
Contributor

Looking through the logs now...

I encourage you to set -DWITH_TESTS=NO in the formula.

alexreinking
alexreinking reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all for being on top of updating the Homebrew package! And I'm sorry for my part in making the process a little more complicated this time around. But hopefully these patches resolve our issue 🙂

Formula/h/halide.rb Outdated Show resolved Hide resolved
Formula/h/halide.rb Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 18, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 18, 2024
@alexreinking
Copy link
Contributor

Ah, disabling the tutorials seems to have broken your package tests.

@daeho-ro
Copy link
Member

@alexreinking That is right, I was modified but forgot to push and noticed now lol.

@daeho-ro daeho-ro removed help wanted Task(s) needing PRs from the community or maintainers upstream issue An upstream issue report is needed test failure CI fails while running the test-do block labels Dec 18, 2024
@daeho-ro
Copy link
Member

Thank you, @alexreinking 👍 Everything is fine now.

@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Dec 18, 2024
chenrui333
chenrui333 reviewed Dec 18, 2024
View reviewed changes
Formula/h/halide.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 18, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 18, 2024
BrewTestBot and others added 2 commits December 19, 2024 00:20
@BrewTestBot @alexreinking @daeho-ro
halide 19.0.0
9738f45 
Co-authored-by: Alex Reinking <[email protected]>
@chenrui333 @daeho-ro
wabt: revision bump for linux bottle
0609dac 
Fix relocation error when linking shared libraries on Linux

```
  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: /home/linuxbrew/.linuxbrew/lib/libwabt.a(binary-reader.cc.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
  /home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: final link failed: bad value
  collect2: error: ld returned 1 exit status
```

build log re, https://github.com/Homebrew/homebrew-core/actions/runs/12369250671/job/34520913923#step:4:4511

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member

Thanks @alexreinking, @daeho-ro. :shipit:

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit a63a460 Dec 18, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-halide-19.0.0 branch December 18, 2024 16:03
carlocab
carlocab reviewed Dec 18, 2024
View reviewed changes
Formula/w/wabt.rb
Comment on lines +38 to +39
system "cmake", *args, *std_cmake_args

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step seems redundant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro left review comments

@carlocab carlocab carlocab left review comments

@alexreinking alexreinking alexreinking left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrewTestBot @daeho-ro @chenrui333 @alexreinking @carlocab